Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show root problem list for objects with problem and are part of dependency #1057

Merged
merged 8 commits into from
Oct 31, 2024
Merged

Show root problem list for objects with problem and are part of dependency #1057

merged 8 commits into from
Oct 31, 2024

Conversation

raviks789
Copy link
Contributor

@raviks789 raviks789 commented Sep 17, 2024 •
edited
Loading

ref #1050

blocked by: #1055
blocked by: Icinga/ipl-web#231, Icinga/ipl-web#234

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Sep 17, 2024
@raviks789 raviks789 force-pushed the root-problem-list branch 10 times, most recently from bc06e1c to 3375e51 Compare September 19, 2024 13:14
@raviks789 raviks789 changed the title WIP Show root problem list for objects that have problem and are part of dependency Sep 19, 2024
@raviks789 raviks789 changed the title Show root problem list for objects that have problem and are part of dependency Show root problem list for objects with problem and are part of dependency Sep 19, 2024
@raviks789 raviks789 force-pushed the root-problem-list branch 5 times, most recently from 4351639 to e77c687 Compare September 23, 2024 07:52
@raviks789 raviks789 marked this pull request as ready for review September 23, 2024 12:19
@nilmerg nilmerg linked an issue Sep 24, 2024 that may be closed by this pull request
Show a list of root problems in the host/service detail if it has a problem and is part of a dependency #1050
Closed
@nilmerg nilmerg added the enhancement New feature or improvement label Sep 24, 2024
nilmerg
nilmerg requested changes Sep 24, 2024
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase, #1055 is merged.

library/Icingadb/Common/StateBadges.php Outdated Show resolved Hide resolved
library/Icingadb/Common/StateBadges.php Outdated Show resolved Hide resolved
library/Icingadb/Common/StateBadges.php Outdated Show resolved Hide resolved
library/Icingadb/Widget/RedundancyGroupParentStateBadges.php Outdated Show resolved Hide resolved
library/Icingadb/Widget/RedundancyGroupParentStateBadges.php Outdated Show resolved Hide resolved
library/Icingadb/Widget/Detail/ObjectDetail.php Show resolved Hide resolved
library/Icingadb/Widget/RedundancyGroupStatistics.php Outdated Show resolved Hide resolved
library/Icingadb/Widget/RedundancyGroupStatistics.php Outdated Show resolved Hide resolved
library/Icingadb/Widget/ItemList/RedundancyGroupListItem.php Outdated Show resolved Hide resolved
library/Icingadb/Widget/ItemList/RedundancyGroupListItem.php Outdated Show resolved Hide resolved
@raviks789 raviks789 force-pushed the root-problem-list branch 2 times, most recently from b41bdb3 to 18db2a7 Compare September 26, 2024 13:11
sukhwinder33445
sukhwinder33445 reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add PhpDoc and method return type to newly introduced classes/methods.

application/controllers/ServiceController.php Show resolved Hide resolved
public/css/list/redundancy-group-list-item.less Outdated Show resolved Hide resolved
library/Icingadb/Widget/ItemList/RedundancyGroupListItem.php Outdated Show resolved Hide resolved
library/Icingadb/Widget/ObjectsStateBadges.php Outdated Show resolved Hide resolved
library/Icingadb/Widget/ObjectsStateBadges.php Outdated Show resolved Hide resolved
library/Icingadb/Model/RedundancyGroupParentStateSummary.php Outdated Show resolved Hide resolved
library/Icingadb/Model/Behavior/HasRootProblem.php Outdated Show resolved Hide resolved
library/Icingadb/Common/StateBadges.php Outdated Show resolved Hide resolved
library/Icingadb/Common/StateBadges.php Outdated Show resolved Hide resolved
library/Icingadb/Common/StateBadges.php Outdated Show resolved Hide resolved
@raviks789 raviks789 force-pushed the root-problem-list branch 2 times, most recently from e059950 to 0320436 Compare October 28, 2024 16:11
sukhwinder33445
sukhwinder33445 previously requested changes Oct 28, 2024
View reviewed changes
library/Icingadb/Common/StateBadges.php Outdated Show resolved Hide resolved
library/Icingadb/Redis/VolatileStateResults.php Show resolved Hide resolved
library/Icingadb/Model/Behavior/HasProblematicParent.php Outdated Show resolved Hide resolved
nilmerg
nilmerg requested changes Oct 29, 2024
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of StateBadges::getUrl(), phpstan is right, it's a public interface where we cannot guarantee noone will use it unless a url has been set.

public/css/list/redundancy-group-list-item.less Outdated Show resolved Hide resolved
@raviks789 raviks789 force-pushed the root-problem-list branch 4 times, most recently from fbf2475 to baa46d7 Compare October 30, 2024 11:22
nilmerg
nilmerg requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to test restrictions, however

library/Icingadb/Model/Behavior/HasProblematicParent.php Outdated Show resolved Hide resolved
nilmerg
nilmerg approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raviks789 raviks789 force-pushed the root-problem-list branch 2 times, most recently from d630538 to f2ffe25 Compare October 30, 2024 15:58
@nilmerg nilmerg merged commit a7fb07b into dependencies Oct 31, 2024
22 checks passed
@nilmerg nilmerg deleted the root-problem-list branch October 31, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg approved these changes

@sukhwinder33445 sukhwinder33445 sukhwinder33445 left review comments

Assignees

@raviks789 raviks789

Labels
cla/signed CLA is signed by all contributors of a PR enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show a list of root problems in the host/service detail if it has a problem and is part of a dependency
3 participants
@raviks789 @sukhwinder33445 @nilmerg