Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObjectInspectionDetail: Render 'n. a.' if $command is empty #846

Merged
merged 1 commit into from
Aug 21, 2023
Merged

ObjectInspectionDetail: Render 'n. a.' if $command is empty #846

merged 1 commit into from
Aug 21, 2023

Conversation

sukhwinder33445
Copy link
Contributor

fixes #845

@sukhwinder33445 sukhwinder33445 self-assigned this Aug 21, 2023
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Aug 21, 2023
@sukhwinder33445 sukhwinder33445 added bug Something isn't working area/ui Affects the user interface labels Aug 21, 2023
nilmerg
nilmerg requested changes Aug 21, 2023
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should look the same as the other n.a. occurrences. It makes also no sense to allow copying it.

@sukhwinder33445 sukhwinder33445 force-pushed the fix/dont-render-empty-command-in-source-tab branch from 9baf057 to 4a4e4fd Compare August 21, 2023 11:03
@nilmerg
Copy link
Member

nilmerg commented Aug 21, 2023

I've also meant you to remove the code block look:
image

Otherwise the contrast ratio is too low.

@sukhwinder33445 sukhwinder33445 force-pushed the fix/dont-render-empty-command-in-source-tab branch from 4a4e4fd to 43f5a9b Compare August 21, 2023 13:57
@nilmerg nilmerg added area/representation Affects the representation of information and removed area/ui Affects the user interface labels Aug 21, 2023
@nilmerg nilmerg added this to the 1.1.0 milestone Aug 21, 2023
@nilmerg nilmerg merged commit 1aaa95e into master Aug 21, 2023
11 checks passed
@nilmerg nilmerg deleted the fix/dont-render-empty-command-in-source-tab branch August 21, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg approved these changes

Assignees

@sukhwinder33445 sukhwinder33445

Labels
area/representation Affects the representation of information bug Something isn't working cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Executed command section in source tab looks odd
2 participants
@sukhwinder33445 @nilmerg