Raise phpstan level to max

.github/workflows/php.yml

@@ -31,20 +31,21 @@ jobs:
           tools: phpcs
 
       - name: Setup dependencies
-        run: composer require -n --no-progress overtrue/phplint
-          && git clone --single-branch --branch master https://github.com/Icinga/icingaweb2.git vendor/icingaweb2
-          && git clone --single-branch --branch master https://github.com/Icinga/icingadb-web.git vendor/modules/icingadb-web
-          && git clone --single-branch --branch snapshot/nightly https://github.com/Icinga/icinga-php-library.git vendor/icinga-php-library
-          && git clone --single-branch --branch snapshot/nightly https://github.com/Icinga/icinga-php-thirdparty.git vendor/icinga-php-thirdparty
+        run: |
+          composer require -n --no-progress overtrue/phplint
+          git clone --depth 1 https://github.com/Icinga/icingaweb2.git vendor/icingaweb2
+          git clone --depth 1 https://github.com/Icinga/icingadb-web.git vendor/modules/icingadb-web
+          git clone --depth 1 -b snapshot/nightly https://github.com/Icinga/icinga-php-library.git vendor/icinga-php-library
+          git clone --depth 1 -b snapshot/nightly https://github.com/Icinga/icinga-php-thirdparty.git vendor/icinga-php-thirdparty
 
       - name: PHP Lint
-        if: success() || matrix.allow_failure
+        if: ${{ ! cancelled() }}
         run: ./vendor/bin/phplint -n --exclude={^vendor/.*} -- .
 
       - name: PHP CodeSniffer
-        if: success() || matrix.allow_failure
+        if: ${{ ! cancelled() }}
         run: phpcs -wps --colors
 
       - name: PHPStan
+        if: ${{ ! cancelled() }}
         uses: php-actions/phpstan@v3
-        if: success() || matrix.allow_failure

library/Cube/DimensionParams.php

@@ -59,11 +59,11 @@ public function add($dimension)
      *
      * @param $dimensions
      *
-     * @return $this
+     * @return DimensionParams
      */
     public static function update($dimensions)
     {
-        $self =  new static();
+        $self = new static();
         $self->dimensions = $dimensions;
 
         return $self;

library/Cube/Ido/IdoCube.php

@@ -42,6 +42,25 @@ abstract class IdoCube extends DbCube
 
     public const IS_USING_ICINGADB = false;
 
+    /**
+     * Add a specific named dimension
+     *
+     * Right now these are just custom vars, we might support group memberships
+     * or other properties in future
+     *
+     * @param string $name
+     *
+     * @return $this
+     */
+    public function addDimensionByName($name): self
+    {
+        if (count($this->filterProtectedCustomvars([$name])) === 1) {
+            $this->addDimension($this->createDimension($name));
+        }
+
+        return $this;
+    }
+
     /**
      * We can steal the DB connection directly from a Monitoring backend
      *

library/Cube/Ido/IdoHostStatusCube.php

@@ -44,24 +44,6 @@ public function createDimension($name)
         return new CustomVarDimension($name, CustomVarDimension::TYPE_HOST);
     }
 
-    /**
-     * Add a specific named dimension
-     *
-     * Right now this are just custom vars, we might support group memberships
-     * or other properties in future
-     *
-     * @param string $name
-     * @return $this
-     */
-    public function addDimensionByName($name)
-    {
-        if (count($this->filterProtectedCustomvars(array($name))) === 1) {
-            $this->addDimension($this->createDimension($name));
-        }
-
-        return $this;
-    }
-
     /**
      * This returns a list of all available Dimensions
      *

library/Cube/Ido/IdoServiceStatusCube.php

@@ -84,25 +84,6 @@ public function prepareInnerQuery()
         return $select;
     }
 
-    /**
-     * Add a specific named dimension
-     *
-     * Right now this are just custom vars, we might support group memberships
-     * or other properties in future
-     *
-     * @param string $name
-     *
-     * @return $this
-     */
-    public function addDimensionByName($name)
-    {
-        if (count($this->filterProtectedCustomvars([$name])) === 1) {
-            $this->addDimension($this->createDimension($name));
-        }
-
-        return $this;
-    }
-
     public function createDimension($name)
     {
         $this->registerAvailableDimensions();

library/Cube/Web/Controller.php

@@ -14,6 +14,7 @@
 use Icinga\Module\Icingadb\Web\Control\ProblemToggle;
 use Icinga\Web\View;
 use Icinga\Web\Widget\Tabextension\DashboardAction;
+use ipl\Html\FormElement\CheckboxElement;
 use ipl\Html\HtmlString;
 use ipl\Stdlib\Filter;
 use ipl\Stdlib\Str;
@@ -96,7 +97,9 @@ protected function renderCube(): void
         $problemToggle = (new ProblemToggle($problemsOnly ?: null))
             ->setIdProtector([$this->getRequest(), 'protectId'])
             ->on(ProblemToggle::ON_SUCCESS, function (ProblemToggle $form) {
-                if (! $form->getElement('problems')->isChecked()) {
+                /** @var CheckboxElement $problems */
+                $problems = $form->getElement('problems');
+                if (! $problems->isChecked()) {
                     $this->redirectNow(Url::fromRequest()->remove('problems'));
                 } else {
                     $this->redirectNow(Url::fromRequest()->setParam('problems'));