Cleanup code (#237)

Icinga · May 8, 2024 · a160960 · a160960
2 parents f523bc8 + b04f85d
commit a160960
Show file tree

Hide file tree

Showing 14 changed files with 22 additions and 318 deletions.
diff --git a/application/controllers/ConfigController.php b/application/controllers/ConfigController.php
@@ -11,14 +11,14 @@
 
 class ConfigController extends Controller
 {
-    public function init()
+    public function init(): void
     {
         $this->assertPermission('config/modules');
 
         parent::init();
     }
 
-    public function backendAction()
+    public function backendAction(): void
     {
         $form = (new SelectBackendForm())
             ->setIniConfig(Config::module('reporting'));
@@ -29,7 +29,7 @@ public function backendAction()
         $this->view->form = $form;
     }
 
-    public function mailAction()
+    public function mailAction(): void
     {
         $form = (new ConfigureMailForm())
             ->setIniConfig(Config::module('reporting'));

diff --git a/application/controllers/PlugController.php.disabled b/application/controllers/PlugController.php.disabled
diff --git a/application/controllers/ReportController.php b/application/controllers/ReportController.php
@@ -29,7 +29,7 @@ class ReportController extends Controller
     /** @var Report */
     protected $report;
 
-    public function init()
+    public function init(): void
     {
         $reportId = $this->params->getRequired('id');
 
@@ -46,7 +46,7 @@ public function init()
         $this->report = Report::fromModel($report);
     }
 
-    public function indexAction()
+    public function indexAction(): void
     {
         $this->addTitleTab($this->report->getName());
 
@@ -89,7 +89,7 @@ public function contentAction(): void
         }
     }
 
-    public function cloneAction()
+    public function cloneAction(): void
     {
         $this->assertPermission('reporting/reports');
         $this->addTitleTab($this->translate('Clone Report'));
@@ -128,7 +128,7 @@ public function cloneAction()
         $this->addContent($form);
     }
 
-    public function editAction()
+    public function editAction(): void
     {
         $this->assertPermission('reporting/reports');
         $this->addTitleTab($this->translate('Edit Report'));
@@ -170,7 +170,7 @@ public function editAction()
         $this->addContent($form);
     }
 
-    public function sendAction()
+    public function sendAction(): void
     {
         $this->addTitleTab($this->translate('Send Report'));
 
@@ -190,7 +190,7 @@ public function sendAction()
         $this->addContent($form);
     }
 
-    public function scheduleAction()
+    public function scheduleAction(): void
     {
         $this->assertPermission('reporting/schedules');
         $this->addTitleTab($this->translate('Schedule'));
@@ -227,7 +227,7 @@ public function scheduleAction()
         }
     }
 
-    public function downloadAction()
+    public function downloadAction(): void
     {
         $type = $this->params->getRequired('type');
 
@@ -274,7 +274,7 @@ public function downloadAction()
         }
     }
 
-    protected function assembleActions()
+    protected function assembleActions(): ActionBar
     {
         $reportId = $this->report->getId();
 

diff --git a/application/controllers/ReportController.php.modal b/application/controllers/ReportController.php.modal
diff --git a/application/controllers/ReportsController.php b/application/controllers/ReportsController.php
@@ -20,7 +20,7 @@ class ReportsController extends Controller
 {
     use ReportsTimeframesAndTemplatesTabs;
 
-    public function indexAction()
+    public function indexAction(): void
     {
         $this->createTabs()->activate('reports');
 
@@ -95,7 +95,7 @@ public function indexAction()
         }
     }
 
-    public function newAction()
+    public function newAction(): void
     {
         $this->assertPermission('reporting/reports');
         $this->addTitleTab($this->translate('New Report'));

diff --git a/application/controllers/TemplateController.php b/application/controllers/TemplateController.php
@@ -25,7 +25,7 @@ class TemplateController extends Controller
     /** @var Model\Template */
     protected $template;
 
-    public function init()
+    public function init(): void
     {
         parent::init();
 
@@ -41,7 +41,7 @@ public function init()
         $this->template = $template;
     }
 
-    public function indexAction()
+    public function indexAction(): void
     {
         $this->addTitleTab($this->translate('Preview'));
 
@@ -60,7 +60,7 @@ public function indexAction()
         $this->addContent($template);
     }
 
-    public function editAction()
+    public function editAction(): void
     {
         $this->assertPermission('reporting/templates');
         $this->addTitleTab($this->translate('Edit Template'));

diff --git a/application/controllers/TemplatesController.php b/application/controllers/TemplatesController.php
@@ -19,7 +19,7 @@ class TemplatesController extends Controller
 {
     use ReportsTimeframesAndTemplatesTabs;
 
-    public function indexAction()
+    public function indexAction(): void
     {
         $this->createTabs()->activate('templates');
 
@@ -92,7 +92,7 @@ public function indexAction()
         }
     }
 
-    public function newAction()
+    public function newAction(): void
     {
         $this->assertPermission('reporting/templates');
         $this->addTitleTab($this->translate('New Template'));

diff --git a/application/controllers/TimeframeController.php b/application/controllers/TimeframeController.php
@@ -20,7 +20,7 @@ class TimeframeController extends Controller
     /** @var Timeframe */
     protected $timeframe;
 
-    public function init()
+    public function init(): void
     {
         /** @var Model\Timeframe $timeframe */
         $timeframe = Model\Timeframe::on(Database::get())
@@ -34,7 +34,7 @@ public function init()
         $this->timeframe = Timeframe::fromModel($timeframe);
     }
 
-    public function editAction()
+    public function editAction(): void
     {
         $this->assertPermission('reporting/timeframes');
         $this->addTitleTab($this->translate('Edit Time Frame'));

diff --git a/application/controllers/TimeframesController.php b/application/controllers/TimeframesController.php
@@ -19,7 +19,7 @@ class TimeframesController extends Controller
 {
     use ReportsTimeframesAndTemplatesTabs;
 
-    public function indexAction()
+    public function indexAction(): void
     {
         $this->createTabs()->activate('timeframes');
 
@@ -102,7 +102,7 @@ public function indexAction()
         }
     }
 
-    public function newAction()
+    public function newAction(): void
     {
         $this->assertPermission('reporting/timeframes');
         $this->addTitleTab($this->translate('New Timeframe'));