Recommend package installs & enhance installation & configuration docs #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabteab
changed the title
yhabteab
force-pushed
the
docs-enhancements
branch
3 times, most recently
from
b977a4c
to
cab9938
Compare
nilmerg
added
enhancement
lippserd
previously requested changes
Sep 18, 2023
yhabteab
force-pushed
the
docs-enhancements
branch
from
cab9938
to
f6752ea
Compare
yhabteab
force-pushed
the
docs-enhancements
branch
from
f6752ea
to
12df246
Compare
nilmerg
requested changes
Sep 18, 2023
yhabteab
force-pushed
the
docs-enhancements
branch
from
12df246
to
ae11dbf
Compare
nilmerg
previously approved these changes
Sep 18, 2023
yhabteab
force-pushed
the
docs-enhancements
branch
2 times, most recently
from
d0b2c83
to
b5dfbff
Compare
yhabteab
force-pushed
the
docs-enhancements
branch
from
1db8173
to
cd85fa0
Compare
nilmerg
approved these changes
Sep 20, 2023
nilmerg
requested changes
Oct 16, 2023
yhabteab
force-pushed
the
docs-enhancements
branch
from
cd85fa0
to
301c869
Compare
nilmerg
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
I've also tested this locally as if rendered on the website. Looks fine, albeit the notice in 03-Configuration.md about the install without packages will not be hidden there, as the template macros are not evaluated in this context. But that's not a problem here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #196