Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeframeForm: Fix relative datetime handling #244

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

TimeframeForm: Fix relative datetime handling #244

wants to merge 2 commits into from

Commits on Jul 23, 2024

  1. TimeframeForm: Add validator to end element 

    End date must always be greater than the start date

- Add autosubmit to validate on every change
    @sukhwinder33445
    sukhwinder33445 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e4d3866 View commit details
    Browse the repository at this point in the history

  2. TimeframeForm: Fix DateTime handling 

    - `DateTime::createFromFormat()` returns false, if seconds are `00`, which leads to a false positive result at the end.
- Check the checkboxes only if start/end is actually relative
    @sukhwinder33445
    sukhwinder33445 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    2d2277e View commit details
    Browse the repository at this point in the history