Merge pull request #80 from Icinga/fix/strlimit

Improve str::limit function
Icinga · Aug 12, 2024 · 1335408 · 1335408
2 parents c4066bd + c664fc4
commit 1335408
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/library/Toplevelview/Util/Str.php b/library/Toplevelview/Util/Str.php
@@ -15,6 +15,10 @@ class Str
      */
     public static function limit($str, $len = 25, $end = '...'): string
     {
+        if (empty($str)) {
+            return '';
+        }
+
        // If the string is smaller or equal to the limit we simply return it
         if (mb_strwidth($str, 'UTF-8') <= $len) {
             return $str;

diff --git a/test/php/library/Toplevelview/Util/StrTest.php b/test/php/library/Toplevelview/Util/StrTest.php
@@ -9,6 +9,7 @@ final class StrTest extends TestCase
 {
     public function testLimitWithSmallerString()
     {
+        $this->assertSame('', Str::limit(null));
         $this->assertSame('', Str::limit(''));
         $this->assertSame('noop', Str::limit('noop'));
     }
@@ -19,6 +20,10 @@ public function testLimitWithLongerStringAndSpecificLimit()
             'Lorem ipsu...',
             Str::limit('Lorem ipsum dolor sit amet, consectetur adipiscing elit.', 10)
         );
+        $this->assertSame(
+            '🍔🍔🍔🍔🍔...',
+            Str::limit('🍔🍔🍔🍔🍔🍔🍔🍔', 10)
+        );
     }
 
     public function testLimitWithLongerStringAndSpecificEnd()
@@ -27,5 +32,13 @@ public function testLimitWithLongerStringAndSpecificEnd()
             'L (...)',
             Str::limit('Lorem ipsum dolor sit amet, consectetur adipiscing elit.', 1, ' (...)')
         );
+        $this->assertSame(
+            'К (...)',
+            Str::limit('Кто это читает, тот дурак', 1, ' (...)')
+        );
+        $this->assertSame(
+            'К (🦔🦔🦔)',
+            Str::limit('Кто это читает, тот дурак', 1, ' (🦔🦔🦔)')
+        );
     }
 }