Release/v1.0 #73
Merged
Release/v1.0 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViewConfig represented both the data and the controller (loading/storing) data. This change seperates these concepts into two classes. This is in preparation for adding restrictions.
Refactor Views and ViewConfig
Add view and edit restrictions
Some minor CSS fixes
Improve stylesheet and TLV Overview
- so that it is differeny from the @tlv-color-ok-bg
Add more validation for YAML configuration
Add option to toggle notification_enabled behavior
- Had to refactor the class a bit for simpler testing
Reasoning: The mental model was a bit confusing, since the Model\View reads the YAML and has a Tree attribute, while this Tree had the same View as attribute. But we only need some attributes from the View in the Tree, might even be possible to use Model\View instead of Tree in some cases and then use view->getTree().
* Fix restrictions for form operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for preparing the Release v1.0.0
Fixes #4
Fixes #26
Fixes #62
Fixes #67
Fixes #69