Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RRule: Include set timezone in serialized result #38

Merged

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Mar 29, 2023

fixes #37
blocked by #39

@nilmerg nilmerg added the bug Something isn't working label Mar 29, 2023
@nilmerg nilmerg requested a review from yhabteab March 29, 2023 08:08
@nilmerg nilmerg self-assigned this Mar 29, 2023
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Mar 29, 2023
@nilmerg nilmerg force-pushed the fix/invalid-rrule-once-end-date-is-set-35 branch from 408d789 to 15a841b Compare March 29, 2023 11:32
@nilmerg nilmerg force-pushed the fix/rrule-does-not-include-tz-during-serialization-37 branch from 932c18b to 27cdc0a Compare March 29, 2023 11:33
@nilmerg nilmerg force-pushed the fix/invalid-rrule-once-end-date-is-set-35 branch from 15a841b to 34ae36a Compare March 29, 2023 12:20
@yhabteab yhabteab added this to the 0.1.1 milestone Mar 29, 2023
@nilmerg nilmerg force-pushed the fix/invalid-rrule-once-end-date-is-set-35 branch 2 times, most recently from b245755 to 9203f0a Compare March 29, 2023 13:11
@nilmerg nilmerg force-pushed the fix/rrule-does-not-include-tz-during-serialization-37 branch from 27cdc0a to 3a37b53 Compare March 29, 2023 13:14
@nilmerg
Copy link
Member Author

nilmerg commented Mar 29, 2023

Partly obsolete since #40, but for UNTIL still relevant.

@nilmerg nilmerg force-pushed the fix/invalid-rrule-once-end-date-is-set-35 branch 2 times, most recently from 84046bc to 3851485 Compare March 29, 2023 15:16
@nilmerg nilmerg force-pushed the fix/rrule-does-not-include-tz-during-serialization-37 branch from 3a37b53 to 43a3539 Compare March 29, 2023 15:28
@nilmerg nilmerg force-pushed the fix/invalid-rrule-once-end-date-is-set-35 branch from 3851485 to 2109c0c Compare March 30, 2023 08:07
@nilmerg nilmerg force-pushed the fix/rrule-does-not-include-tz-during-serialization-37 branch 2 times, most recently from 21c5061 to e22c2de Compare March 30, 2023 08:25
@nilmerg nilmerg force-pushed the fix/invalid-rrule-once-end-date-is-set-35 branch from 2109c0c to 86264cc Compare March 30, 2023 08:27
@nilmerg nilmerg changed the base branch from fix/invalid-rrule-once-end-date-is-set-35 to main March 30, 2023 08:27
tests/RRuleTest.php Show resolved Hide resolved
tests/RRuleTest.php Outdated Show resolved Hide resolved
@nilmerg nilmerg force-pushed the fix/rrule-does-not-include-tz-during-serialization-37 branch from e22c2de to d4891ad Compare April 3, 2023 08:12
@yhabteab yhabteab merged commit d0fa442 into main Apr 3, 2023
@yhabteab yhabteab deleted the fix/rrule-does-not-include-tz-during-serialization-37 branch April 3, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RRule does not include set timezone during serialization
2 participants