Don't render empty footer list items

Icinga · Sep 8, 2023 · 0ff36d9 · 0ff36d9
1 parent 4bea1d2
commit 0ff36d9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/asset/css/list/list-item.less b/asset/css/list/list-item.less
@@ -38,9 +38,7 @@
   }
 
   footer {
-    &:not(:empty) {
-      padding-top: .5em;
-    }
+    padding-top: .5em;
   }
 }
 

diff --git a/src/Common/BaseListItem.php b/src/Common/BaseListItem.php
@@ -85,11 +85,14 @@ protected function createMain(): BaseHtmlElement
         return $main;
     }
 
-    protected function createFooter(): BaseHtmlElement
+    protected function createFooter(): ?BaseHtmlElement
     {
         $footer = new HtmlElement('footer');
 
         $this->assembleFooter($footer);
+        if ($footer->isEmpty()) {
+            return null;
+        }
 
         return $footer;
     }