-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
js/Add search term attributes #70
Conversation
48c0fc2
to
7d30184
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides my comments:
- If the term direction is vertical
- I think pressing
Delete
orBackspace
should have no effect while in the main input. - If
Backspace
is pressed on a term it should also be ignored, butDelete
should probably still remove the term. - Pushing
Ctrl+a
, copying and pasting content should be ignored (makes no sense)
- I think pressing
- If the terms are read only
- The events
onKeyUp
,onInputBlur
,onTermFocusOut
andonTermFocus
are completely useless and shouldn't run
- The events
- Override the methods
isReadOnlyMode
andisTermDirectionVertical
in classFilterInput
and return alwaysfalse
there. It isn't adjusted to support these and it makes no sense at this time anway.
fe42110
to
09b78fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took only a look at the JS changes yet.
3071739
to
08511c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also:
- The trash icon should only appear upon hover
d17b807
to
5352d14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Pasting content auto submits, however you have disabled it, seems to be ignored
- Also exact matches and pushing enter submits the form. This may be the default behavior, but the
TermInput
should treat this as "autosubmit" and then act depending on whether that's disabled or not.
- Also exact matches and pushing enter submits the form. This may be the default behavior, but the
- Stylewise, the search field should look the same as the search bar. The terms as well. The search icon should also be the same, though not necessarily have the same color. (It's not interactive after all)
- The trash icon should apply a blur effect. The input should have a slightly darker backgorund once hovered.
01f074a
to
09b7953
Compare
d13b349
to
569cafd
Compare
569cafd
to
29239d0
Compare
9961b93
to
1f90cc1
Compare
a9ee49e
to
5816848
Compare
803eadf
to
d0f4a75
Compare
1f90cc1
to
0f326b5
Compare
0f326b5
to
23a8ed9
Compare
c560971
to
20a7a22
Compare
23a8ed9
to
530d463
Compare
20a7a22
to
bb1f502
Compare
530d463
to
d2c7b49
Compare
No description provided.