Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port Settings DAO to use PDO #539

Merged
merged 4 commits into from
Dec 20, 2021
Merged

Port Settings DAO to use PDO #539

merged 4 commits into from
Dec 20, 2021

Commits on Dec 14, 2021

  1. Extract PDO connection logic to DatabaseConnectionManager. 

    This should ease the implementation of PDO in other DAOs. Besides, it
will allow to reuse the connection for all DAO objects instead of
creating a new one every time.
    @jaragunde
    jaragunde committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    06f54e8 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. Move PDO object up in the DAO hierarchy to BaseDAO. 

    This makes it accessible to other DAOs extending BaseDAO.
    @jaragunde
    jaragunde committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    1b83e5c View commit details
    Browse the repository at this point in the history

  2. Remove unused operation ConfigDAO::getVersionNumber().

    @jaragunde
    jaragunde committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    c868e06 View commit details
    Browse the repository at this point in the history

  3. Port PostgreSQLConfigDAO to use PDO.

    @jaragunde
    jaragunde committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    81a521d View commit details
    Browse the repository at this point in the history