Port Extra Hour DAO to use PDO #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VO had to be modified for PDO::FETCH_ALL to work properly: * The $userId property had to match the name in the DB. * The $date property was being set as a string from the originally stored value. We override the __set() magic method to take care of the conversion into a DateTime object.
It's not needed after we migrate all the getters to use PDO.
We also remove unnecessary checks for the row id in update and delete operations.
Fixes: * Undefined index: sid * Undefined variable: string
anarute
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #513, also includes a patch for #431 and removes unused code.