Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(theming): changing how taas applies themes #3241

Open
wants to merge 13 commits into
base: vnext
Choose a base branch
from

Conversation

ChronosSF
Copy link
Member

@ChronosSF ChronosSF commented Jan 27, 2023

@ChronosSF
Copy link
Member Author

This needs to be merged in conjunction with a codegen service update and a widget update so I am putting a label until we are ready for the push.

Comment on lines +5 to +6
'igx-theme': 'material-light',
'igx-dark-theme': 'material-dark',
Copy link
Collaborator

@simeonoff simeonoff Jan 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'igx-theme': 'material-light',
'igx-dark-theme': 'material-dark',
'igx-material-light': 'material-light',
'igx-material-dark': 'material-dark',

I believe all themes are of equal importance and we should have material in the name for that reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants