Skip to content

refactor(*): bundle styles with components #15125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 131 commits into
base: master
Choose a base branch
from
Draft

refactor(*): bundle styles with components #15125

wants to merge 131 commits into from

Conversation

@simeonoff
Copy link
Collaborator

@simeonoff simeonoff commented Dec 2, 2024 •
edited
Loading

Closes #13770

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

simeonoff and others added 30 commits November 6, 2024 17:27
@simeonoff
initial commit
1f903bb
@simeonoff
refactor(*): test scoping with container queries
552a2a7
@simeonoff
refactor(avatar): update styles
6baebc3
@simeonoff
Merge branch 'master' into simeonoff/scoped-styles
dc1f0bb
@simeonoff
Merge branch 'master' into simeonoff/scoped-styles
130c20e
@simeonoff
Merge branch 'master' into simeonoff/scoped-styles
4fc2c48
@simeonoff
refactor(checkbox): bundle styles with component - initial commit
5a4ca22
@simeonoff
refactor(checkbox): fix component styles
754ec5b
@simeonoff
build(styles): don't rely on theme service for bundled styles
0a5378d
@simeonoff
refactor(styles): add themed component styles to a layer
83e7bbd
@simeonoff
demos(theme): update
b99884e
@simeonoff
refactor(avatar): update base theme
5e2372c
@simeonoff
Merge branch 'master' into simeonoff/scoped-styles
17a9b1c
@simeonoff
fix(avatar): icon size
444c21f
@simeonoff
Merge branch 'master' into simeonoff/scoped-styles
e7564e8
@simeonoff
build(lig): build component styles before library
a2b7306
@SisIvanova
refactor(icon): bundle styles with component (#15281)
363035e
@simeonoff
fix(checkbox): make light themes functional again
8c013b2
@simeonoff
fix(checkbox): dark themes
d27f37d
@simeonoff
refactor(checkbox): untagle placeholder selectors
5338438
@simeonoff
Merge branch 'master' into simeonoff/scoped-styles
2c30a5c
@simeonoff
npm(package-lock): revert changes
e9038bd
@simeonoff
npm(package-lock): revert changes
094e5b6
@simeonoff
npm(package.json): revert file order
052cb39
@simeonoff
build(npm): add back concurrently
6d2a79f
@simeonoff
deps(node-watch): add back node-watch
9add91c
@simeonoff
chore(*): remove some changes
ba4184b
@simeonoff
build(scripts): global themes not building
1c0df4a
@simeonoff
fix(checkbox): wrong tickmark in both indeterminate and checked
c1d1ad6
@simeonoff
refactor(checkbox): organize variables better
9514481
SisIvanova and others added 30 commits June 19, 2025 18:20
@SisIvanova
fix(combo/select): remove suffix dynamically (#15961)
61b886d
@SisIvanova
refactor(drop-down): items icon size (#15968)
9830b62
@desig9stein
refactor(input-group, textarea): label position
b28b211 
handle placeholder with css
@desig9stein
refactor(input-group): refactor file type input structure
a9eea25
@simeonoff
Merge branch 'master' into simeonoff/scoped-styles
cfbc684
@simeonoff
fix(theme-token): match implementation in master
39033cb
@simeonoff
deps(theming): bump to latest version
0ed89b1
@desig9stein
fix(input-group): fix the showcase sample
0c28b20
@desig9stein
chore(igniteui-webcomponents): bump to v6.1.1
1f8db21
@desig9stein
fix(input-group): use the file schema colors
4be085b
@adrianptrv
fix(grid & combo): remove grid column actions negative margin & fix c…
1ed9b26 
…ombo clear button parameters (#15966)

* fix(grid & combo): remove grid negative margin & fix combo clear button parameters

* fix(combo): fix spacing
@desig9stein
refactor(input-group, textarea): label position (#15953)
9da28d7 
handle placeholder with css
@SisIvanova
fix(radio-group): dynamically added radio buttons do not initialize (#…
9e56f70 
…16042)
@SisIvanova
fix(date-picker): indigo theme elevations (#16085)
9bdcc1e
@adrianptrv
fix(textarea): suffix space (#16140)
e09d808
@adrianptrv
fix(input-group): prefix & suffix bootstrap border (#16151)
6141c64
@didimmova @simeonoff
feat(combo): fix combo initial dropdown height (#16171)
710b3ee 
* feat(combo): fix combo initial dropdown height

* refactor(themes): update dropdown theme to use a CSS variable for item count

---------

Co-authored-by: Simeon Simeonoff <[email protected]>
@simeonoff
Merge branch 'master' into simeonoff/scoped-styles
c9acc60
@simeonoff
fix(demos): not running after merging master
28a023e
@simeonoff
lint(stylelint): fix errors
0f609be
@simeonoff
spec(*): tests not running
4e89eb9
@desig9stein
fix(input-group): fix broken input group after the merge conflict
e057b8e
@desig9stein
fix(button-group): remove unnecessary bootstrap-specific styles (#16260)
a397802 
- We should not remove a border or any schema-connected style from the theme. Rather, we should update the variable in the schema, which in this case is already done.
@desig9stein
fix(card): make sure that actions text color is not overriding the bu…
78b8506 
…tton themes (#16265)
@simeonoff
Merge branch 'master' into simeonoff/scoped-styles
e348163
@simeonoff
fix(tooltip): post-merge theme fixes
3d63a25
@adrianptrv @simeonoff
feat(checkbox): set tick-width property - (scoped) (#16321)
448483c 
* feat(checkbox): set tick-width property

* chore(theming): bump version to 22.0.0-beta.1

* deps(theming): bump to latest version

---------

Co-authored-by: Simeon Simeonoff <[email protected]>
@didimmova
feat(timepicker): update timepicker sample with properties panel (#16340
c0c9e4f 
)
@SisIvanova
refactor(input-group): add readonly styles (#16328)
06b8a51 
* refactor(input-group): add readonly styles

* fix(input-group): material border styles
@SisIvanova @simeonoff
refactor(input-group): input refinement (#16307)
44d6711 
* refactor(input-group): input refinement

* refactor(input-group): address review comments

* fix(input-group): helper text issue

* Update _core.scss

---------

Co-authored-by: Simeon Simeonoff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@adrianptrv adrianptrv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Themes: Scope component styles to component

6 participants

@simeonoff @adrianptrv @SisIvanova @kdinev @desig9stein @didimmova