-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(elements-grid): Add content children ready event. #15226
Open
MayaKirova
wants to merge
4
commits into
master
Choose a base branch
from
mkirova/feat-15050
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+55
−7
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,9 +66,16 @@ class IgxCustomNgElementStrategy extends ComponentNgElementStrategy { | |
(this as any).componentRef = {}; | ||
|
||
const toBeOrphanedChildren = Array.from(element.children).filter(x => !this._componentFactory.ngContentSelectors.some(sel => x.matches(sel))); | ||
const contentChildren = Array.from(element.children).filter(x => this._componentFactory.ngContentSelectors.some(sel => x.matches(sel))); | ||
for (const iterator of toBeOrphanedChildren) { | ||
// TODO: special registration OR config for custom | ||
} | ||
|
||
if (contentChildren.length === 0) { | ||
// no content children, emit event immediately, since there's nothing to be attached. | ||
(this as any).componentRef?.instance?.childrenAttached?.emit(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, might want to emit this after the component has actually initialized - around the end of this method. |
||
} | ||
|
||
let parentInjector: Injector; | ||
let parentAnchor: ViewContainerRef; | ||
const parents: IgcNgElement[] = []; | ||
|
@@ -307,6 +314,10 @@ class IgxCustomNgElementStrategy extends ComponentNgElementStrategy { | |
list.reset(childRefs); | ||
list.notifyOnChanges(); | ||
} | ||
if (this.schedule.size === 0) { | ||
// children are attached and collections are updated, emit event. | ||
(this as any).componentRef?.instance?.childrenAttached?.emit(); | ||
} | ||
} | ||
|
||
private runQueryInDOM(element: HTMLElement, query: ContentQueryMeta): IgcNgElement[] { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might need some more refinement since
ngContentSelectors
will give all projected children and not all of those need to have a content query (e.g. the state component right now) which won't schedule any query updates and thus won't trigger the event at all.Should be possible to further filter the children through their matching config, need the
component
orprovideAs
to match those against thecomponentConfig.contentQueries[n].childType
-s so we know for sure a child is expected to run query update and leave the emit for that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, further annoying bit can be the
descendants
bit on the query, might need to account for that as well