Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(radio): bundle styles with component #15294

Merged
merged 8 commits into from
Feb 7, 2025
Merged

refactor(radio): bundle styles with component #15294

merged 8 commits into from
Feb 7, 2025

Conversation

SisIvanova
Copy link
Collaborator

Closes #15243

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@SisIvanova SisIvanova marked this pull request as ready for review February 5, 2025 13:33
@SisIvanova SisIvanova requested a review from simeonoff February 5, 2025 13:33
@SisIvanova SisIvanova linked an issue Feb 6, 2025 that may be closed by this pull request
[Radio Group]: Bundle theme styles to component #15243
Closed
simeonoff
simeonoff reviewed Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@simeonoff simeonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the most part everything looks good. Just some minor remarks.

projects/igniteui-angular/src/lib/radio/radio.component.ts Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/radio/themes/_base.scss Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/radio/themes/_base.scss Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/radio/themes/_base.scss Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/radio/themes/dark/_fluent.scss Show resolved Hide resolved
@SisIvanova SisIvanova requested a review from simeonoff February 7, 2025 09:19
@SisIvanova SisIvanova added the ❌ status: awaiting-test PRs awaiting manual verification label Feb 7, 2025
@simeonoff simeonoff added design: verified ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification design: verified labels Feb 7, 2025
@simeonoff simeonoff merged commit 5788f15 into simeonoff/scoped-styles Feb 7, 2025
@simeonoff simeonoff deleted the sivanova/radio-scoped-styles branch February 7, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonoff simeonoff simeonoff approved these changes

Assignees
No one assigned
Labels
radio-button radio-group refactoring ✨ themes ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Radio Group]: Bundle theme styles to component
2 participants
@SisIvanova @simeonoff