-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(igxGrid): Apply min/max width constraints on user-set and auto-w… #15449
base: master
Are you sure you want to change the base?
Conversation
@ChronosSF @dkamburov @damyanpetev @kdinev A question arose around one of the existing tests: In that test the scenario is the following:
Small width, no user set min-width. Previously this allowed the user to set such a width initially. Resulting in a column with 50px width. However for user interaction, there's a defaultMinWidth, based on the current density: For instance, here: https://www.infragistics.com/products/ignite-ui-angular/angular/components/grid/column-resizing#angular-grid-column-resizing-example I believe these defaults had something to do with the different paddings in the cells, which are different for the different densities. Since below a certain threshold with the paddings you can no longer see the content of the cell and it's no longer a meaningful render. @simeonoff might have more insight. So the question is: Should this defaultMinWidth be applied as constraint to the initially set width of the column or not? If it does, this might be a breaking change, since user that have set a small width initially, with no min-width, will render the column with default min instead. For example, user has set 50px width, but since defaultMinWidth is 80, the column will be 80px when rendered. Let me know what you think. |
I don't think this |
…idths.
Closes #15383
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)