Skip to content

Conversation

@wnvko
Copy link
Contributor

@wnvko wnvko commented Nov 7, 2025

Two things in this PR:

  • fix the way toggle directive shows its target. In open method we set now collapsed to false and call detect changes. In old versions of Angular this updates the related host bindings immediately. As a result we have the target element visible and can measure and position it correctly. In post Ivy versions host bindings are updated on next cycle and to have target element visible we need to wait. This is what the fix is for. More information about this change in Angular here.
  • make the position strategy of grid toolbar dropdowns auto.

Closes #16410

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@wnvko wnvko added 🛠️ status: in-development Issues and PRs with active development on them toggle grid: toolbar version: 21.0.x labels Nov 7, 2025
@wnvko wnvko marked this pull request as draft November 7, 2025 08:47
@wnvko
Copy link
Contributor Author

wnvko commented Nov 7, 2025

@copilot fix all the failing tests

Copy link
Contributor

Copilot AI commented Nov 7, 2025

@wnvko I've opened a new pull request, #16430, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Grid] The chosen positioning strategy for toolbar dropdowns causes them to not display their full contents in certain scenarios

2 participants