Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tree grid sorting topic #1249

Merged
merged 8 commits into from
Jun 7, 2024
Merged

Add tree grid sorting topic #1249

merged 8 commits into from
Jun 7, 2024

Conversation

georgianastasov
Copy link
Contributor

@georgianastasov georgianastasov commented Apr 10, 2024 •
edited
Loading

for react

@georgianastasov georgianastasov added the status: awaiting-test ❌ PR ready for testing label Apr 10, 2024
@kacheshmarova kacheshmarova requested a review from RivaIvanova June 6, 2024 08:43
RivaIvanova
RivaIvanova reviewed Jun 6, 2024
View reviewed changes
Copy link
Member

@RivaIvanova RivaIvanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the code snippets correspond to the grid samples and not the tree grid ones.

RivaIvanova
RivaIvanova reviewed Jun 6, 2024
View reviewed changes
Copy link
Member

@RivaIvanova RivaIvanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to the Angular Tree Grid Sorting code snippets here and keep in mind this issue.

@MonikaKirkova MonikaKirkova added status: verified ✅ The PR is tested and ready for a merge and removed status: awaiting-test ❌ PR ready for testing labels Jun 7, 2024
@kacheshmarova kacheshmarova merged commit 2ab2f95 into vnext Jun 7, 2024
10 checks passed
@kacheshmarova kacheshmarova deleted the ganastasov/tree-grid-sorting-topic branch June 7, 2024 10:42
randriova added a commit that referenced this pull request Jun 7, 2024
@randriova
Updating JA for #1262, #1249 and #1252.
960ff5c
@randriova randriova added the status: localized indicates that localization is complete label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RivaIvanova RivaIvanova RivaIvanova left review comments

@MonikaKirkova MonikaKirkova MonikaKirkova approved these changes

@dkamburov dkamburov Awaiting requested review from dkamburov

Assignees
No one assigned
Labels
status: localized indicates that localization is complete status: verified ✅ The PR is tested and ready for a merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@georgianastasov @MonikaKirkova @RivaIvanova @kacheshmarova @randriova