Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit row-editting topic and update toc #907

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Conversation

onlyexeption
Copy link
Contributor

No description provided.

@onlyexeption onlyexeption added the status: do not merge things not ready/risky for merging label Jul 3, 2023
@onlyexeption onlyexeption requested a review from dkamburov July 3, 2023 10:50
Copy link
Contributor

@MayaKirova MayaKirova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few snippets that show for the base grid but are missing for the tree grid:

  1. In the Row Editing Usage section, the data binding snippet for the grid is there:
    image
    but is missing for the treegrid:
    image
  2. Tree grid snippet in the styling section is also missing:
    image

@onlyexeption onlyexeption requested a review from MayaKirova July 5, 2023 14:35
MayaKirova
MayaKirova previously approved these changes Jul 6, 2023
@MayaKirova MayaKirova marked this pull request as ready for review December 21, 2023 08:58
@MayaKirova MayaKirova self-requested a review December 21, 2023 08:58
@MayaKirova MayaKirova removed the status: do not merge things not ready/risky for merging label Dec 21, 2023
@dkamburov dkamburov merged commit 22298aa into vnext Dec 21, 2023
10 checks passed
@dkamburov dkamburov deleted the ibarakov/tgrid-row-editing branch December 21, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants