Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar bs removal #680

Closed
wants to merge 90 commits into from
Closed

Navbar bs removal #680

wants to merge 90 commits into from

Conversation

abhushanaj
Copy link
Member

fixes #580

Summary of the changes:

  • Removed dependency of BS4
  • Added custom styles on the navbar

Here's the working example:
The video might lag a little
Ignitus

gargshruti30 and others added 27 commits March 24, 2020 22:43
Aggregation of signup components sharing same functionality
Search, account and Notification icons
Interest Flow migrated to => Emotion. 🔨

export const DropDownContainer = styled.div`
padding: 3rem;
`;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline required at end of file but not found eol-last

@@ -0,0 +1,5 @@
import styled from '@emotion/styled';

export const DropDownContainer = styled.div`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer default export import/prefer-default-export

@@ -0,0 +1 @@
export {default as interfaceDropDown} from './interfaceDropDown';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is required after '{' object-curly-spacing
A space is required before '}' object-curly-spacing
Prefer default export import/prefer-default-export

@@ -0,0 +1 @@
export const cars = ['volvo', 'mercedes', 'audi', 'bmw'];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer default export import/prefer-default-export


export const atomsEdges: Edges[] = [
export const edges: Edges[] = [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing error: Unexpected token :

</nav>
);


const Navigation = () => {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing spaces not allowed no-trailing-spaces

<span className="line mobile"></span>
<span className="line mobile"></span>
</div>

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing spaces not allowed no-trailing-spaces

<div id="burger" onClick={handleSmallerScreen}>
<span className="line mobile"></span>
<span className="line mobile"></span>
<span className="line mobile"></span>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty components are self-closing react/self-closing-comp


<div id="burger" onClick={handleSmallerScreen}>
<span className="line mobile"></span>
<span className="line mobile"></span>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty components are self-closing react/self-closing-comp

</div>

<div id="burger" onClick={handleSmallerScreen}>
<span className="line mobile"></span>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty components are self-closing react/self-closing-comp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removal of Bootstrap 4 in Nav-bar. 🎨
6 participants