-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navbar bs removal #680
Navbar bs removal #680
Conversation
Migrated ignitus-GetStarted files to TS
Added replacement for lodash methods under ignitus-UtilityFunctions
vulnerability fixes, package updates, lodash removal.
Added 3 svg icons
… into anjali-icons
Added 8 SVG icons
Aggregation of signup components sharing same functionality
Search, account and Notification icons
Interest Flow migrated to => Emotion. 🔨
|
||
export const DropDownContainer = styled.div` | ||
padding: 3rem; | ||
`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline required at end of file but not found eol-last
@@ -0,0 +1,5 @@ | |||
import styled from '@emotion/styled'; | |||
|
|||
export const DropDownContainer = styled.div` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer default export import/prefer-default-export
@@ -0,0 +1 @@ | |||
export {default as interfaceDropDown} from './interfaceDropDown'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A space is required after '{' object-curly-spacing
A space is required before '}' object-curly-spacing
Prefer default export import/prefer-default-export
@@ -0,0 +1 @@ | |||
export const cars = ['volvo', 'mercedes', 'audi', 'bmw']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer default export import/prefer-default-export
|
||
export const atomsEdges: Edges[] = [ | ||
export const edges: Edges[] = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parsing error: Unexpected token :
</nav> | ||
); | ||
|
||
|
||
const Navigation = () => { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing spaces not allowed no-trailing-spaces
<span className="line mobile"></span> | ||
<span className="line mobile"></span> | ||
</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing spaces not allowed no-trailing-spaces
<div id="burger" onClick={handleSmallerScreen}> | ||
<span className="line mobile"></span> | ||
<span className="line mobile"></span> | ||
<span className="line mobile"></span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty components are self-closing react/self-closing-comp
|
||
<div id="burger" onClick={handleSmallerScreen}> | ||
<span className="line mobile"></span> | ||
<span className="line mobile"></span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty components are self-closing react/self-closing-comp
</div> | ||
|
||
<div id="burger" onClick={handleSmallerScreen}> | ||
<span className="line mobile"></span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty components are self-closing react/self-closing-comp
fixes #580
Summary of the changes:
Here's the working example:
The video might lag a little