Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mater > Develop (WIP) ☘️ #686

Merged
merged 67 commits into from
Mar 28, 2020
Merged

Mater > Develop (WIP) ☘️ #686

merged 67 commits into from
Mar 28, 2020

Conversation

divyanshu-rawat
Copy link
Member

@divyanshu-rawat divyanshu-rawat commented Mar 25, 2020

  1. Introduction of Input Field Component. Added default Input html element component. #677 ★.
  2. Email Flow migrated to => Emotion Email Flow migrated to => Emotion #679 🚀
  3. Email Confirmation Flow migrated to => Emotion Email Confirmation Flow migrated to => Emotion #685 ⚓️
  4. BS4 => Pure CSS Navigation Bar. BS4 => Pure CSS Navigation Bar. #681 🔨
  5. UI Kit changes 🎯 UI Kit changes 🎯 #694
  6. Added opportunities saved layout. ★. Added opportunities saved layout. ★ #693
  7. Search Input UI ☘️ Search Input UI ☘️ #689
  8. Pure footer ★☘️🚀🎯 Pure footer ★☘️🚀🎯 #699

@@ -0,0 +1,5 @@
export type InputType = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing error: Unexpected token type

@@ -0,0 +1 @@
export { default as DefaultInput } from './defaultInput';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline required at end of file but not found eol-last
Prefer default export import/prefer-default-export

import * as C from '../colors';
import * as F from '../fonts';

export const Input = styled.input`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer default export import/prefer-default-export

import { InputType } from '../types'
import { Input } from '../styles';

const DefaultInput = ({placeholder, type, name}: InputType) => (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing error: Unexpected token :

@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #686 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##              master        #686   +/-   ##
=============================================
  Coverage   15.20190%   15.20190%           
=============================================
  Files             48          48           
  Lines            421         421           
  Branches         100         100           
=============================================
  Hits              64          64           
  Misses           357         357           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9b2308...f9b2308. Read the comment docs.

<Link to="/">I don’t see the email</Link>
</WhiteButton>
</C.ButtonContainer>
<Paragraph><Link to="/">I don’t want to confirm my email yet.</Link></Paragraph>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is required for an anchor to be keyboard accessible. Provide a valid, navigable address as the href value. If you cannot provide an href, but still need the element to resemble a link, use a button and change it with appropriate styles. Learn more: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md jsx-a11y/anchor-is-valid

<Link to="/flow/emailConfirmationFlow">Email confirmed</Link>
</PrimaryButton>
<WhiteButton>
<Link to="/">I don’t see the email</Link>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is required for an anchor to be keyboard accessible. Provide a valid, navigable address as the href value. If you cannot provide an href, but still need the element to resemble a link, use a button and change it with appropriate styles. Learn more: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md jsx-a11y/anchor-is-valid

<T.BottomSection>
<C.ButtonContainer>
<PrimaryButton>
<Link to="/flow/emailConfirmationFlow">Email confirmed</Link>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is required for an anchor to be keyboard accessible. Provide a valid, navigable address as the href value. If you cannot provide an href, but still need the element to resemble a link, use a button and change it with appropriate styles. Learn more: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md jsx-a11y/anchor-is-valid

@@ -0,0 +1,2 @@
/* eslint-disable import/prefer-default-export */
export {default as EmailFlow} from './EmailFlow';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is required after '{' object-curly-spacing
A space is required before '}' object-curly-spacing

@@ -0,0 +1,6 @@
import styled from '@emotion/styled';
import {BottomRow} from '../../../../ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/atoms';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is required after '{' object-curly-spacing
A space is required before '}' object-curly-spacing

@divyanshu-rawat divyanshu-rawat temporarily deployed to ignitus-pipe-develop-5joevkgdn March 25, 2020 19:32 Inactive
@divyanshu-rawat divyanshu-rawat temporarily deployed to ignitus-pipe-develop-5joevkgdn March 25, 2020 21:09 Inactive
@@ -0,0 +1,2 @@
/* eslint-disable import/prefer-default-export */
export {default as EmailConfirmationFlow} from './EmailConfirmationFlow';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is required after '{' object-curly-spacing
A space is required before '}' object-curly-spacing

</T.TopSection>
<C.BottomSection>
<RoundedPrimaryButton>
<Link to="/">Get started</Link>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is required for an anchor to be keyboard accessible. Provide a valid, navigable address as the href value. If you cannot provide an href, but still need the element to resemble a link, use a button and change it with appropriate styles. Learn more: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md jsx-a11y/anchor-is-valid

'Church and civil courts in late medieval and early modern Melbourne.',
subtitle: 'By The University of PortsMouth',
src: Melbourne,
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing trailing comma comma-dangle

@@ -0,0 +1,18 @@
import Melbourne from '../../../../ignitus-Shared/ignitus-DesignSystem/ignitus-Assets/ignitus-Images/img-Png/universityOfMelbourne.png';

export const List = [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer default export import/prefer-default-export

@@ -0,0 +1 @@
export {};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline required at end of file but not found eol-last

<StyledHeading2>Opportunities Saved Layout ★</StyledHeading2>
<hr />
<Grid>
{List.map(({title, description, subtitle, src}: Opportunity) => (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing error: Unexpected token :

@@ -0,0 +1 @@
export { default as interfaceSavedOpportunity } from './interfaceSavedOpportunity';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline required at end of file but not found eol-last
Prefer default export import/prefer-default-export

display: flex;
justify-content: center;
align-items: center;
margin-right:1rem;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colon after property should be followed by one space

font-weight: $ignite-font-weight-bold;
font-size: $ignite-font-size-xs;
.navlinks{
display: flex;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered align-items, display, justify-content, margin-right

color: $ignite-color-blue-20;
font-weight: $ignite-font-weight-bold;
font-size: $ignite-font-size-xs;
.navlinks{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opening curly brace { should be preceded by one space

.navbar {
align-items: center;
display:flex;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colon after property should be followed by one space

description,
subtitle,
src,
}: Opportunity) => (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing error: Unexpected token :

@divyanshu-rawat divyanshu-rawat had a problem deploying to ignitus-pipe-develop-6h8a9gmps March 28, 2020 16:20 Failure
@@ -1,5 +1,5 @@
import styled from '@emotion/styled';

export const CardLayoutContainer = styled.nav`
export const SearchInputContainer = styled.nav`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer default export import/prefer-default-export

<DefaultSearchInput
placeholder={'Search @user'}
type={'text'}
name={'name'}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curly braces are unnecessary here react/jsx-curly-brace-presence


<DefaultSearchInput
placeholder={'Search @user'}
type={'text'}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curly braces are unnecessary here react/jsx-curly-brace-presence

<hr />

<DefaultSearchInput
placeholder={'Search @user'}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curly braces are unnecessary here react/jsx-curly-brace-presence

import { StyledHeading2 } from '../../../../styles';

const interfaceTypography = () => (
<SearchInputContainer>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSX not allowed in files with extension '.tsx' react/jsx-filename-extension

import {IgnitusBlue, Red, Grey1} from '../colors';
import {SM} from '../fonts';
import Icon from '../../../ignitus-Utilities/Components/icon';
import {flexibleRowDiv} from '../../shared';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is required after '{' object-curly-spacing
A space is required before '}' object-curly-spacing

@@ -0,0 +1,33 @@
import styled from '@emotion/styled';
import {IgnitusBlue, Red, Grey1} from '../colors';
import {SM} from '../fonts';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is required after '{' object-curly-spacing
A space is required before '}' object-curly-spacing

@@ -0,0 +1,33 @@
import styled from '@emotion/styled';
import {IgnitusBlue, Red, Grey1} from '../colors';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is required after '{' object-curly-spacing
A space is required before '}' object-curly-spacing

import {AppIcon} from '../../../../types/iconsTypes/enums';
import * as I from '../styles';

const DefaultSearchInput = ({placeholder, type, name}: InputTypes) => (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing error: Unexpected token :

@@ -0,0 +1 @@
export {default as DefaultSearchInput} from './defaultSearchInput';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is required after '{' object-curly-spacing
A space is required before '}' object-curly-spacing
Prefer default export import/prefer-default-export

@divyanshu-rawat divyanshu-rawat had a problem deploying to ignitus-pipe-develop-6h8a9gmps March 28, 2020 17:01 Failure
@@ -1,10 +1,10 @@
import styled from '@emotion/styled';
import * as C from './ignitus-Atoms/colors';
import * as F from './ignitus-Atoms/fonts';
import { mq } from './ignitus-Atoms/media';
import {mq} from './ignitus-Atoms/media';
import {Heading3} from './ignitus-Atoms/typography';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is required after '{' object-curly-spacing
A space is required before '}' object-curly-spacing

@@ -1,10 +1,10 @@
import styled from '@emotion/styled';
import * as C from './ignitus-Atoms/colors';
import * as F from './ignitus-Atoms/fonts';
import { mq } from './ignitus-Atoms/media';
import {mq} from './ignitus-Atoms/media';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is required after '{' object-curly-spacing
A space is required before '}' object-curly-spacing

lines.forEach((line) => {
line.classList.toggle('mobile');
});
navlinks?.classList.toggle('mobile');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing error: Unexpected token .

@@ -3,6 +3,7 @@ import * as T from '../../../ignitus-Shared/ignitus-DesignSystem/shared';
import * as C from '../../../ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/colors';
import PlusIcon from '../../../ignitus-Shared/ignitus-DesignSystem/ignitus-Assets/ignitus-Icons/plusIcon/plusIcon';
import ChevronIcon from '../../../ignitus-Shared/ignitus-DesignSystem/ignitus-Assets/ignitus-Icons/chevronIcon/chevronIcon';
import {Paragraph} from '../../../ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/typography';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is required after '{' object-curly-spacing
A space is required before '}' object-curly-spacing

font-weight: 600;
font-size: 22px;
color: #000066;
color: #000066;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color literals like #000066 should only be used in variable declarations; they should be referred to via variable everywhere else.
Property color already defined on line 10


.testimonial {
.testimonials-title {
text-align: center;
font-weight: 600;
font-size: 22px;
color: #000066;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color literals like #000066 should only be used in variable declarations; they should be referred to via variable everywhere else.

@import "./src/ignitus-Shared/styles/ignitus-tokens";
@import "./src/ignitus-Shared/styles/ignitus-mixins";
@import './src/ignitus-Shared/styles/ignitus-tokens';
@import './src/ignitus-Shared/styles/ignitus-mixins';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings

@@ -1,10 +1,14 @@
// import ignitus token variables
@import "./src/ignitus-Shared/styles/ignitus-tokens";
@import "./src/ignitus-Shared/styles/ignitus-mixins";
@import './src/ignitus-Shared/styles/ignitus-tokens';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings

@divyanshu-rawat divyanshu-rawat temporarily deployed to ignitus-pipe-develop-6h8a9gmps March 28, 2020 18:56 Inactive
import { Heading3 } from '../../ignitus-Atoms/typography';
import { White, SecondaryColor, IgnitusBlue } from '../../ignitus-Atoms/colors';

type FooterLinkprops = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing error: Unexpected token FooterLinkprops

@@ -0,0 +1 @@
export{};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected space(s) after "export" keyword-spacing
Newline required at end of file but not found eol-last

@@ -0,0 +1 @@
export{};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected space(s) after "export" keyword-spacing
Newline required at end of file but not found eol-last

@@ -0,0 +1,3 @@
// eslint-disable-next-line import/prefer-default-export
export const logo: string =
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing error: Unexpected token :

@@ -0,0 +1 @@
export{};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected space(s) after "export" keyword-spacing
Newline required at end of file but not found eol-last

<li> <a target="_blank" href="https://twitter.com/ignitus_org/"> <i className="fa fa-twitter"/></a> </li>
<li> <a target="_blank" href="https://angel.co/ignitus-2"> <i className="fa fa-angellist"/></a> </li>
<li> <a target="_blank" href="https://bit.ly/JoinIgnitusSlack"> <i className="fa fa-slack"/></a> </li>
<li> <a target="_blank" href="https://www.linkedin.com/company/13733583/admin/updates/"> <i className="fa fa-linkedin"/></a> </li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is required before closing bracket react/jsx-tag-spacing
Using target="_blank" without rel="noopener noreferrer" is a security risk: see https://mathiasbynens.github.io/rel-noopener react/jsx-no-target-blank

<li> <a target="_blank" href="https://www.facebook.com/Ignitus.org/"> <i className="fa fa-facebook"/></a> </li>
<li> <a target="_blank" href="https://twitter.com/ignitus_org/"> <i className="fa fa-twitter"/></a> </li>
<li> <a target="_blank" href="https://angel.co/ignitus-2"> <i className="fa fa-angellist"/></a> </li>
<li> <a target="_blank" href="https://bit.ly/JoinIgnitusSlack"> <i className="fa fa-slack"/></a> </li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is required before closing bracket react/jsx-tag-spacing
Using target="_blank" without rel="noopener noreferrer" is a security risk: see https://mathiasbynens.github.io/rel-noopener react/jsx-no-target-blank

<S.FooterSocial>
<li> <a target="_blank" href="https://www.facebook.com/Ignitus.org/"> <i className="fa fa-facebook"/></a> </li>
<li> <a target="_blank" href="https://twitter.com/ignitus_org/"> <i className="fa fa-twitter"/></a> </li>
<li> <a target="_blank" href="https://angel.co/ignitus-2"> <i className="fa fa-angellist"/></a> </li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is required before closing bracket react/jsx-tag-spacing
Using target="_blank" without rel="noopener noreferrer" is a security risk: see https://mathiasbynens.github.io/rel-noopener react/jsx-no-target-blank

<S.Socials>
<S.FooterSocial>
<li> <a target="_blank" href="https://www.facebook.com/Ignitus.org/"> <i className="fa fa-facebook"/></a> </li>
<li> <a target="_blank" href="https://twitter.com/ignitus_org/"> <i className="fa fa-twitter"/></a> </li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is required before closing bracket react/jsx-tag-spacing
Using target="_blank" without rel="noopener noreferrer" is a security risk: see https://mathiasbynens.github.io/rel-noopener react/jsx-no-target-blank


<S.Socials>
<S.FooterSocial>
<li> <a target="_blank" href="https://www.facebook.com/Ignitus.org/"> <i className="fa fa-facebook"/></a> </li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is required before closing bracket react/jsx-tag-spacing
Using target="_blank" without rel="noopener noreferrer" is a security risk: see https://mathiasbynens.github.io/rel-noopener react/jsx-no-target-blank

@divyanshu-rawat divyanshu-rawat merged commit 2a56aea into master Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants