Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better account status #196

Conversation

pecataToshev
Copy link
Contributor

I've created an improved account status function with view of all resorces and all buildings in one place. Also it's colorful, so one can easily determine what to do. Also added an option to view the whole finances table in the console.

@pecataToshev pecataToshev force-pushed the better-account-status branch 2 times, most recently from ba84f55 to 9f6f4fc Compare December 23, 2023 09:36
@pecataToshev
Copy link
Contributor Author

Fixed issue with missing multiple buildings with the same name and simplified the print resource printing

@ElieTaillard ElieTaillard added the release notes Items are likely to be highlighted in the release notes. label Dec 27, 2023
@ElieTaillard ElieTaillard added this to the 6.7.0 milestone Dec 27, 2023
@ikagod
Copy link
Collaborator

ikagod commented Jan 4, 2024

Thank you so much for the work you do on these PRs, I really appreciate it. Unfortunately I am very much against adding new dependencies for things like this. I've said this many times before, Ikabot is not supposed to be beautiful, it's supposed to be functional and lightweight. If we wanted it to look pretty, we would have an actual GUI lol. Packages like beautifulsoup are unnecessary. I know we could have added it a long time ago and used it project-wide but it's too late for that now. Just regex whatever you need from the html, it's not that hard.
There was a similar PR some time ago (#110) that wanted to add bs4 and I rejected it for the same reasons.

As for the actual account status changes, I really don't know what makes these "better" other than the colors. I think the additional information is just too excessive, and too unnecessary.

Right now I will close this PR and I regret to inform you that this will most probably not make it into the ikabot main branch, but I am always open to listing your fork of ikabot in a wiki page that lists other ikabot related project (which still doesn't exist but we've been talking about it forever now.)

@ikagod ikagod closed this Jan 4, 2024
@ElieTaillard
Copy link
Member

ElieTaillard commented Jan 5, 2024

I'd like to share some additional thoughts regarding this PR. Firstly, I want to highlight Ikabot's history, starting on Linux and expanding over the years. The project has evolved through the efforts of dedicated volunteers, and I believe this evolution signifies the project's significance to the community.

Adding dependencies may raise concerns, but I also believe it can contribute to standardization and user satisfaction. The recurring requests for aesthetic improvements in previous PRs clearly indicate community interest in a more user-friendly interface. It's crucial to consider the evolving user needs over time.

Currently, the project is maintained by volunteer contributors, and the diversity of users, including those on Windows and running locally, demonstrates the need to adapt the application to these various requirements. By enhancing the application's aesthetics, we could not only make the user experience more enjoyable but also broaden the user base, potentially attracting new contributors and ensuring the project's longevity.

I understand concerns about the application's lightweight nature, but I believe finding a balance between functionality and aesthetics could be beneficial for Ikabot's future.

Following your discussions, I took the initiative to incorporate contribution guidelines. These guidelines reflect the desire to refrain from introducing new dependencies and to maintain a lightweight codebase. The goal is to prevent contributors from investing time in modifications that could be deemed unnecessary. These guidelines have been created to bring more clarity to the project's direction and to prevent any redundancy in development efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes Items are likely to be highlighted in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants