Select area to include in deep world dump. #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElieTaillard
added
the
release notes
ikagod
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The world dump is very useful function to me however it takes a very long time to do.
One of the ways to make it scan faster is to limit the scan area by providing start island id however this doesn't give the user much control over which part of the world will be scanned.
This pull request removes limiting area by startid instead it lets user select a circular area which to scan.
It also fixes bug where the percentage scanned was not calculated properly when scanning only part of the map.
The order of choices provided to user was also modified slightly to make more sense.