Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #250 : auto change version in release pipeline #249

Merged

Conversation

ElieTaillard
Copy link
Member

@ElieTaillard ElieTaillard commented Apr 19, 2024

  • Fix change version in release.yml
  • Change version constant name
  • Format files with Black formatter

✅ Pipeline tested on my fork

Should fix #250

@ElieTaillard ElieTaillard requested a review from ikagod April 19, 2024 17:38
@ElieTaillard ElieTaillard added this to the 7.0.1 milestone Apr 19, 2024
@ElieTaillard ElieTaillard changed the title Fix auto change version in release pipeline Fix #250 : auto change version in release pipeline Apr 19, 2024
Copy link
Collaborator

@ikagod ikagod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sorry for not formatting the web server module myself, I don't use the formatter while I'm writing code, only after I'm finished writing I format it, but I totally forgot to do it this time.

@ElieTaillard ElieTaillard merged commit 2c86df9 into Ikabot-Collective:master Apr 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Version Number doesn't change in the release pipeline
2 participants