Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded searching tools for deep scanned islands #261

Merged
merged 4 commits into from
Jun 9, 2024
Merged

Upgraded searching tools for deep scanned islands #261

merged 4 commits into from
Jun 9, 2024

Conversation

AlcapOTP
Copy link
Contributor

@AlcapOTP AlcapOTP commented May 26, 2024 •
edited
Loading

2 new searching options in dumpworld

  1. search by alliance tag. It prints all players of that alliance along with the coordinates for all of their cities.
  2. search for a specific island by coordinates. It prints almost all data about the island contained in the deep scan. See pictures below.
    11
    22
    33

@ElieTaillard ElieTaillard requested a review from ikagod May 28, 2024 03:36
@ElieTaillard ElieTaillard added the release notes Items are likely to be highlighted in the release notes. label Jun 9, 2024
@ElieTaillard ElieTaillard added this to the 7.0.4 milestone Jun 9, 2024
ikagod
ikagod approved these changes Jun 9, 2024
View reviewed changes
Copy link
Collaborator

@ikagod ikagod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I was concerned about the colorama package, but it seems like it has been removed in the latest commits as it is not necessary.

@ikagod ikagod merged commit d16488b into Ikabot-Collective:master Jun 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikagod ikagod ikagod approved these changes

Assignees
No one assigned
Labels
release notes Items are likely to be highlighted in the release notes.
Projects
None yet
Milestone
7.0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@AlcapOTP @ikagod @ElieTaillard