Remove gettext from project #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gettext is unnecessary as ikabot is a relatively small project. We do not have enough resources to add different locales and even if we did, it would require a lot of resources to maintain those localizations when new modules are written in english. To add to this, gettext wasn't even used across the entire project, some modules used it for all strings, some modules used it only for some strings, and not other and some modules didn't use it at all. All in all, I think it's safe to assume ikabot is better off without gettext
ikagod
added
the
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gettext is unnecessary as ikabot is a relatively small project. We do not have enough resources to add different locales and even if we did, it would require a lot of resources to maintain those localizations when new modules are written in english.
To add to this, gettext wasn't even used across the entire project, some modules used it for all strings, some modules used it only for some strings, and not other and some modules didn't use it at all.
All in all, I think it's safe to assume ikabot is better off without gettext