Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add intermediate List/Set decode #269

Merged
merged 8 commits into from
Sep 20, 2024
Merged

feat: Add intermediate List/Set decode #269

merged 8 commits into from
Sep 20, 2024

Conversation

Iltotore
Copy link
Owner

Allow intermerdiate decoding of List[T] and Set[T] exprs, enabling compile-time support for all collection constraints and making Length more flexible.

@Iltotore Iltotore merged commit 576dbaa into main Sep 20, 2024
2 checks passed
@Iltotore Iltotore linked an issue Sep 20, 2024 that may be closed by this pull request
@mio-19
Copy link

mio-19 commented Sep 21, 2024

What about Vector and Seq.apply

@mio-19
Copy link

mio-19 commented Sep 21, 2024

I used many Vector in my codebase

@Iltotore
Copy link
Owner Author

@mio-19 though you are not supposed to directly use Vector in your code base except for some special cases, yes it is possible to support Seq.apply and Vector.apply in compile-time refinement the same way this PR does for List and Set. I'll be glad to review a PR for it.

@mio-19
Copy link

mio-19 commented Sep 25, 2024

@mio-19 though you are not supposed to directly use Vector in your code base except for some special cases

What's the reason for that? I would like to know more about this.

@Iltotore
Copy link
Owner Author

Iltotore commented Oct 1, 2024

@mio-19 though you are not supposed to directly use Vector in your code base except for some special cases

What's the reason for that? I would like to know more about this.

@mio-19 AFAIK it is because it's not the "best-complexity-overall" List implementation so not the one to use by default. People usually use List.apply and Set.apply instead because they (the underlying implementation) were made for the general case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance value-to-expr serialization
2 participants