Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3 Write docs #17

Merged
merged 1 commit into from
Feb 11, 2024
Merged

#3 Write docs #17

merged 1 commit into from
Feb 11, 2024

Conversation

IlyaLisov
Copy link
Owner

@IlyaLisov IlyaLisov commented Feb 11, 2024

PR-Codex overview

This PR focuses on refactoring the storage service implementation classes.

Detailed summary

  • The code has been refactored to use a common find method instead of duplicating code in each service implementation.
  • The exists and delete methods have also been refactored to use the find method internally.
  • The MinIOStorageServiceImpl and FirebaseStorageServiceImpl classes have been updated to use the find method instead of duplicating code.
  • The README.md file has been updated with detailed instructions on how to use the library and contribute to it.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e04e875) 93.54% compared to head (3316c33) 92.52%.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev      #17      +/-   ##
============================================
- Coverage     93.54%   92.52%   -1.03%     
+ Complexity       49       46       -3     
============================================
  Files             5        5              
  Lines           248      214      -34     
  Branches         10        8       -2     
============================================
- Hits            232      198      -34     
  Misses           13       13              
  Partials          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IlyaLisov IlyaLisov merged commit 34256da into dev Feb 11, 2024
4 checks passed
@IlyaLisov IlyaLisov deleted the #3 branch February 11, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant