Skip to content

Commit

Permalink
USD PrimitiveAlgo : Remove comment
Browse files Browse the repository at this point in the history
The remapping discussed appears to be performed for us inside `UsdSkelSkinningQuery::ComputeSkinnedPoints()` and `UsdSkelSkinningQuery::ComputeSkinnedNormals()`, as well as in our new facevarying normals code. That would explain why an attempt to apply it manually would lead to things getting jumbled up.
  • Loading branch information
johnhaddon committed Sep 16, 2024
1 parent 6f9983b commit fd80130
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions contrib/IECoreUSD/src/IECoreUSD/PrimitiveAlgo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -407,10 +407,6 @@ bool readPrimitiveVariables( const pxr::UsdSkelRoot &skelRoot, const pxr::UsdGeo
Canceller::check( canceller );
applyBlendShapes( pointBased, time, skelQuery, skinningQuery, points );

// The UsdSkelBakeSkinning example code uses skinningQuery.GetJointMapper() to remap
// xforms based on a per-prim joint order. However, doing this seems to scramble data
// for UsdSkel crowds exported from Houdini. We don't have any example data that requires
// the joint remapping, so for now we're omiting it in favor of more seamless DCC support.
Canceller::check( canceller );
if( !skinningQuery.ComputeSkinnedPoints( skinningXforms, &points, time ) )
{
Expand Down

0 comments on commit fd80130

Please sign in to comment.