Data type conversion support for lists #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`__dataTypesConversionDict` contains an item that returns a `None` value which would cause an error.
When converting a list, it was simply using the first match, which would often not be the desired one. Ex: converting `["abc", "b"]` to `IECore.CharVectorData( [ 97, 98 ] )`, instead of `IECore.StringVectorData( [ 'abc', 'b' ] )`. The solution here is to use, on lists, the already existing flag on the `__dataTypesConversionDict` entries that indicated the preferred IECore.Data type for a given source. The options selected here as the preferred one when there was ambiguity were the same ones as returned by the simple (non-vector) types. That required a small update to `dataTypeFromElementType()` in order to avoid returning a random return, now that `list` entries in `__dataTypesConversionDict` can have a preferred flag set to `True`.
ivanimanishi
force-pushed
the
dataTypeConversionSupportForLists
branch
from
640cb51
to
53db8e6
Compare
|
Added tests as well. |
ivanimanishi
force-pushed
the
dataTypeConversionSupportForLists
branch
from
53db8e6
to
2b05875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed support for lists when converting to
IECore.Datatypes viaIECore.dataTypeFromElement().Related Issues
Calling
IECore.dataTypeFromElement()for any list would fail with:Once that was fixed, I also had to make sure that it returned the preferred vector type, when there were multiple possible options.
Dependencies
None
Breaking Changes
None
Checklist