CI : Update to GafferHQ/dependencies 7.0.0 #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This header is deprecated, and should be replaced with `boost/test/tools/floating_point_comparison.hpp`. But that doesn't seem to be necessary for the tests to compile or to pass, so I have simply removed the includes.
In Boost 1.77, `evaluate_polynomial` stopped supporting `boost::array`, and started supporting `std::array` instead. We'd prefer to use `std::array` too, but to maintain compatibility with both old and new boost, we just use a plain old array instead.
This means that the packages uploaded for each Cortex release will be suitable for building Gaffer 1.3 with.
|
Updated to include a bunch of Boost/Imath fixes that had escaped attention until now. |
Imath 2 raised RuntimeError here, and Imath 3 raises ValueError instead. These tests date back to when we had our own bindings for Imath, because official bindings didn't exist - it's not even clear that we need them any more.
|
OK, with the latest commit the only failure is a spurious timing-related one that has nothing to do with this PR. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that the packages uploaded for each Cortex release will be suitable for building Gaffer 1.3 with.