Commits on Nov 28, 2023

1. ExceptionAlgo : Fix translatePythonException() reference counting bug …

   The `PyErr_Fetch()` documentation says "you own a reference to each object retrieved", which means we need to decrement the reference count before returning, as we have no interest in sharing ownership. We were doing this via the `boost::python::handle<>` objects in `formatInternal()`, but since d0731a3 we haven't been calling `formatInternal()` for exceptions bound via `IECorePython::ExceptionClass`. That meant we were leaking such Python exceptions such that they would never be destroyed.
   
   The solution, and the moral of the story, is to always hold `PyObject *` via a sensible RAII class like `handle` or `object`, and to always do that _as early as possible_.
   
   You might be forgiven for thinking that leaking a little exception object isn't that big a deal. But Python exceptions have a `__traceback__` attribute that contains the entire stack at the point the exception was raised, and _that_ contains all the local variables from all of those stack frames. So the leak can actually include a completely arbitrary amount of stuff.

   

   johnhaddon committed Nov 28, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 0d615fd
   • Browse repository at this point

   Copy the full SHA

   0d615fd View commit details

   Browse the repository at this point in the history