Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IECoreScene tests : Tighten up a couple test timings #1398

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

danieldresser-ie
Copy link
Contributor

I'm not sure what the correct solution here is long term. John suggested simply removing the wait entirely, and setting the canceller as cancelled before launching the thread we are cancelling. That doesn't really test the right thing though ... we want to make sure that something is still listening for cancellation once the code has had a chance to get into an inner loop.

Without confidence in an ideal solution, I've just made the test timing much tighter, which is probably enough to get the tests passing.

In the case of Triangulate at least, I suspect that what went wrong may be related to actual optimizations that reduced the runtime of the triangulate enough that the wait was too long.

I'm hoping that these values are good enough to stop seeing failures currently, though I'm open to other proposals for the long term.

@johnhaddon
Copy link
Member

Thanks Daniel. Rebased to retarget to RB-10.5, and merging.

@johnhaddon johnhaddon merged commit 6233650 into ImageEngine:RB-10.5 Nov 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants