repr Infinity
#1449
Open
repr Infinity
#1449
+58
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
reviewed
Dec 13, 2024
src/IECorePython/IECoreBinding.cpp
Outdated
Comment on lines
89
to
119
| s << boost::lexical_cast<string>( x[i] );\ | ||
| if constexpr( std::numeric_limits<VEC::BaseType>::has_infinity )\ | ||
| {\ | ||
| s << (\ | ||
| x[i] == std::numeric_limits<VEC::BaseType>::infinity() ? g_positiveInfString :\ | ||
| ( x[i] == -std::numeric_limits<VEC::BaseType>::infinity() ? g_negativeInfString :\ | ||
| boost::lexical_cast<std::string>( x[i] ) ) \ | ||
| );\ | ||
| }\ | ||
| else\ | ||
| {\ | ||
| s << boost::lexical_cast<string>( x[i] );\ | ||
| }\ |
There was a problem hiding this comment.
I think we should omit this special treatment for str(), and limit it only to repr(). The main requirement for str() is that it be simple and readable, which I think we had covered already. Only repr() has the requirement that it generate a string that executes in Python, so I think that's the only place it makes sense to use the Python-specific syntax.
There was a problem hiding this comment.
That makes sense to me. I reverted the str() treatment and added a test to verify str() is correct for inf values and squashed into 3b46e20.
ericmehl
force-pushed
the
serialiseInfinity
branch
from
dc0c599 to
3b46e20
Compare
|
Squashed down a fix for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where
imathvectors and colors with values set to infinity were notrepr-ing in a form that could then beeval-ed.Checklist