Skip to content

IECoreScene CurvesPrimitiveEvaluator : fix vTangent() error #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

proberts-cinesite
Copy link
Contributor

Generally describe what this PR will do, and why it is needed.

IECoreScene.CurvesPrimitiveEvaluator.Result.vTangent() now returns vector pointing in the correct (opposite) direction for curves with Linear interpolation.

Breaking Changes

changes (fixes) bevaviour of function.

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Cortex project's prevailing coding style and conventions.

`IECoreScene.CurvesPrimitiveEvaluator.Result.vTangent()` now returns vector pointing in the correct (opposite) direction for curves with `Linear` interpolation.
@johnhaddon johnhaddon changed the base branch from main to RB-10.5 June 6, 2025 09:22
@johnhaddon johnhaddon changed the base branch from RB-10.5 to main June 6, 2025 09:23
@johnhaddon
Copy link
Member

@ivanimanishi, do you have any concerns about this fix from the IE point of view? It's one of those ones that which is a bugfix but affects the output in a way you might consider to be a breaking change if you'd already adapted to getting the wrong result.

@ivanimanishi
Copy link
Member

It's difficult to be sure it won't cause issues, but I'm willing to try it out and deal with compatibility issues if necessary later.

@johnhaddon
Copy link
Member

I've been through the Gaffer codebase and don't see anything that will be impacted by this fix, so from our point of view we're happy to go ahead in a patch version as well. Paul will update Cinesite's internal code to account for the change when it gets released.

We need to get a release containing #1471 out sharpish, so the plan is to hold back on merging this PR until that is done and then include this in the following release.

@johnhaddon
Copy link
Member

@proberts-cinesite, we need to merge this to RB-10.5 rather than main - could you rebase and update the PR please? If you had time to add test coverage in test/IECoreScene/CurvesPrimitiveEvaluatorTest.py that would be even better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants