Skip to content

Fix memory corrution in ClonePixelWands #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

Fix memory corrution in ClonePixelWands #384

merged 1 commit into from
Oct 28, 2025

Conversation

@4JustMe4
Copy link
Contributor

@4JustMe4 4JustMe4 commented Oct 28, 2025 •
edited
Loading

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practices as demonstrated in the repository.

Description

Size of clone_wands shoud be equal to number_wands times sizeof(*clone_wands). If we use & we can't recieve more than sizeof(PixelWand*) (some constant). So this code will ClonePixelWand into some dirty memory

@dlemstra
Copy link
Member

dlemstra commented Oct 28, 2025

Thanks for fixing this for us! Looks like that typo has been in there for ages.

@dlemstra dlemstra merged commit a8ee3b2 into ImageMagick:main Oct 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@4JustMe4 @dlemstra