Fix blade length #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdeskos
approved these changes
May 31, 2021
gdeskos
reviewed
Jun 1, 2021
| ! Set spannwise and tangential vectors | ||
| sE=(/blade%QCx(nej)-blade%QCx(nej-1),blade%QCy(nej)-blade%QCy(nej-1),blade%QCz(nej)-blade%QCz(nej-1)/) ! nominal element spanwise direction set opposite to QC line | ||
| !sE=(/blade%QCx(nej)-blade%QCx(nej-1),blade%QCy(nej)-blade%QCy(nej-1),blade%QCz(nej)-blade%QCz(nej-1)/) ! nominal element spanwise direction set opposite to QC line | ||
| sE=BEMend-BEMbegin ! nominal element spanwise direction set opposite to QC line |
There was a problem hiding this comment.
Doing sE=BEMend-BEMbegin you assume that the blade has one single pre-bending angle. What about turbine blades with a non-zero and radially variable "pre-bending" angle? You need to maintain the old sE definition!
|
|
||
| sE=sE/sEM | ||
| tE=(/blade%tx(nej)+blade%tx(nej-1),blade%ty(nej)+blade%ty(nej-1),blade%tz(nej)+blade%tz(nej-1)/)/2.0 | ||
| Stotal = Stotal + sEM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the tutorial BlindTests, that comes with the distribution of WInc3D, it was noted that the computed total length of the wind turbine blade (Total length reported: 0.434 m) does not correspond to its radius (0.45 m). The inconsistency is related to how the blade elements are computed from the information in the “blade_geom” file. This error is relevant, as not using the full length of the blade implies the calculation of the forces to be always underpredicted. After modifying the source code files acl_turb.f90 and acl_elem.f90, the correct behaviour was established (Total length reported: 0.45).