-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI test failures #66
Conversation
Unfortunately it seems that the newly minted version of flake8 (5.0.2) is not yet working with the pytest plugin: tholo/pytest-flake8#87 Pin version of flake8 as a workaround.
This reverts commit 4094cf2. There were a bunch of other places where the macOS image name also needed to be updated, so the tests haven't been running since the above commit on macOS. macos-latest should be fine now anyway.
@dalonsoa I've not managed to get the tests working on macOS 😢... Wondering if you had any ideas? Python 3.8 and 3.9 seem to be failing with |
* Skipping TestDialog in MacOS
The deploy step seems to be failing with:
This seems like a bug to me... Should we be trying to upload a new file if the current version is already released? |
No, this is normal - although annoying. PyPI and TestPyPI require unique versions numbers and, at the moment, the version number is constructed counting the number of commits since last version tag. This means that two branches with the same number of commits will result in the same version number, which doesn't work. more elaborate, unique version numbers including the commit hash are not accepted by PyPI or TestPIPY. |
I see... but won't merging be blocked if CI is failing? Other than the deployment failure, the CI checks are all passing, so as long as you're happy with that, I think this is good to review and merge 😄 |
No, only |
Currently our CI is failing because of this upstream issue: tholo/pytest-flake8#87
Fix by pinning flake8 version.
It also seems that tests have not been being run on macOS for some time. This PR also addresses this issue.