Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI test failures #66

Merged
merged 4 commits into from
Aug 5, 2022
Merged

Fix CI test failures #66

merged 4 commits into from
Aug 5, 2022

Conversation

alexdewar
Copy link
Contributor

Currently our CI is failing because of this upstream issue: tholo/pytest-flake8#87
Fix by pinning flake8 version.

It also seems that tests have not been being run on macOS for some time. This PR also addresses this issue.

Unfortunately it seems that the newly minted version of flake8 (5.0.2) is not yet working with the pytest plugin: tholo/pytest-flake8#87

Pin version of flake8 as a workaround.
This reverts commit 4094cf2.

There were a bunch of other places where the macOS image name also
needed to be updated, so the tests haven't been running since the above
commit on macOS. macos-latest should be fine now anyway.
@alexdewar
Copy link
Contributor Author

@dalonsoa I've not managed to get the tests working on macOS 😢... Wondering if you had any ideas? Python 3.8 and 3.9 seem to be failing with macos-latest. I also tried macos-10.15 but then all versions of Python failed 🤷

@alexdewar
Copy link
Contributor Author

The deploy step seems to be failing with:

25hWARNING  Error during upload. Retry with the --verbose option for more details. 
ERROR    HTTPError: 400 Bad Request from https://test.pypi.org/legacy/          
         File already exists. See https://test.pypi.org/help/#file-name-reuse   
         for more information.                                                  

This seems like a bug to me... Should we be trying to upload a new file if the current version is already released?

@dalonsoa
Copy link
Collaborator

dalonsoa commented Aug 5, 2022

No, this is normal - although annoying. PyPI and TestPyPI require unique versions numbers and, at the moment, the version number is constructed counting the number of commits since last version tag. This means that two branches with the same number of commits will result in the same version number, which doesn't work. more elaborate, unique version numbers including the commit hash are not accepted by PyPI or TestPIPY.

@alexdewar
Copy link
Contributor Author

I see... but won't merging be blocked if CI is failing? Other than the deployment failure, the CI checks are all passing, so as long as you're happy with that, I think this is good to review and merge 😄

@dalonsoa
Copy link
Collaborator

dalonsoa commented Aug 5, 2022

No, only Required checks prevent merging. That is not one of them.

@dalonsoa dalonsoa merged commit eea07f9 into develop Aug 5, 2022
@dalonsoa dalonsoa deleted the fix_ci branch August 5, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants