-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated IEA names for 2022 version of WEB #142
base: master
Are you sure you want to change the base?
Conversation
Mmmh, not sure if this is the best approach. That will break any code relying on the previous codes. Please also keep the order of the columns as previous |
Would we then have a new column for each update? And would we retire an old classification after a couple of years? |
Good idea!
Not worried by the number of columns. Let's do iea2022 and duplicates to iea_latest. Not sure which year refers the previous one to?
…________________________________
From: Kajwan ***@***.***>
Sent: Tuesday, 16 May 2023, 15:21
To: IndEcol/country_converter ***@***.***>
Cc: Konstantin Stadler ***@***.***>; Comment ***@***.***>
Subject: Re: [IndEcol/country_converter] Updated IEA names for 2022 version of WEB (PR #142)
Would we then have a new column for each update? And would we retire an old classification after a couple of years?
Perhaps we could keep the latest as IEA, and then add a suffix to the older versions?
—
Reply to this email directly, view it on GitHub<#142 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABTX7SYY6WADL5BEJB4PKX3XGN5OBANCNFSM6AAAAAAYCFSSSA>.
You are receiving this because you commented.Message ID: ***@***.***>
|
The current IEA classification works for 2021 version of the WEB. |
5e65f26
to
e0bcff2
Compare
@konstantinstadler - any other changes I should do or are we ready to merge? |
Would be great to have these new column and the meaning in the readme list (secton classification schemes). |
Please merge with master first again, there was a change in the faror island name |
If you want you can also update the changelog (at the top dev section). But I can do that as well |
No description provided.