Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated IEA names for 2022 version of WEB #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kajwan
Copy link
Contributor

@Kajwan Kajwan commented May 15, 2023

No description provided.

@konstantinstadler
Copy link
Member

Mmmh, not sure if this is the best approach. That will break any code relying on the previous codes.
Perhaps we need to rething the column names for these (IEA2020, IEA2022) ?

Please also keep the order of the columns as previous

@Kajwan
Copy link
Contributor Author

Kajwan commented May 16, 2023

Would we then have a new column for each update? And would we retire an old classification after a couple of years?
Perhaps we could keep the latest as IEA, and then add a suffix to the older versions?

@konstantinstadler
Copy link
Member

konstantinstadler commented May 16, 2023 via email

@Kajwan
Copy link
Contributor Author

Kajwan commented May 16, 2023

The current IEA classification works for 2021 version of the WEB.
If I understand you correctly, then we should have three columns:
IEA_2021 (current version)
IEA_2022 (updated version)
IEA_latest (duplicate of IEA_2022 for now)

@Kajwan Kajwan force-pushed the master branch 2 times, most recently from 5e65f26 to e0bcff2 Compare May 17, 2023 09:13
@Kajwan
Copy link
Contributor Author

Kajwan commented Sep 9, 2023

@konstantinstadler - any other changes I should do or are we ready to merge?

@konstantinstadler
Copy link
Member

Would be great to have these new column and the meaning in the readme list (secton classification schemes).
Also, one very simple test would be great. I had once a case where someone (was it you) was removing some separators which broke other column. So basically just reading the column and checking if one of the entries is in there

@konstantinstadler
Copy link
Member

Please merge with master first again, there was a change in the faror island name

@konstantinstadler
Copy link
Member

If you want you can also update the changelog (at the top dev section). But I can do that as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants