Added column "Continent_7" #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a column "Continent_7" to country_data.tsv where countries are allocated to 7 continents according to https://ourworldindata.org/world-region-map-definitions
|
Hi Marta, you said there was also something wrong with one of the other classifications? Did you fix that as well? |
|
In the existing "Continents", I noticed that the territory of Heard Island and McDonald Islands was classified as "Asia" which does not seem right, but I did not modify it as I wasn't sure which source the continent classification was based on / where to assign it. It's an Australian territory but I think it is often classified as Antarctica. |
|
Ah, ok. Just leave it, I will fix that
…________________________________
From: marthhoi ***@***.***>
Sent: Monday, December 11, 2023 4:43:53 PM
To: IndEcol/country_converter ***@***.***>
Cc: Konstantin Stadler ***@***.***>; Comment ***@***.***>
Subject: Re: [IndEcol/country_converter] Added column "Continent_7" (PR #155)
I noticed that the territory of Heard Island and McDonald Islands was classified as "Asia" which does not seem right, but I did not modify it as I wasn't sure which source the continent classification was based on / where to assign it. It's an Australian territory but I think it is often classified as Antarctica.
—
Reply to this email directly, view it on GitHub<#155 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABTX7S2BLOC4WIPCCLME5LDYI4S3TAVCNFSM6AAAAABAJP3JTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJQGMZTQMZZGI>.
You are receiving this because you commented.Message ID: ***@***.***>
|
konstantinstadler
approved these changes
Dec 12, 2023
|
Looks good, thanks. Will release the update in the next days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a column "Continent_7" to country_data.tsv where countries are allocated to 7 continents according to
https://ourworldindata.org/world-region-map-definitions