Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bonsai #159

Merged
merged 7 commits into from
Nov 15, 2024
Merged

Bonsai #159

merged 7 commits into from
Nov 15, 2024

Conversation

mabudz
Copy link
Contributor

@mabudz mabudz commented Nov 13, 2024

The PR adds the following synonyms to existing classifications:

to ISOnumeric:

  • BACI - BACI: International Trade Database at the Product-Level
  • UNIDO - UNIDO INDSTAT database

to EXIO3:

Furthermore, a new classification GEOnumeric has been added:

  • GEOnumeric GEO numerical codes (also used in Prodcom)

Since the original codes for GEOnumeric is a 4-digit, which starts with "0", I decided to treat those as strings in coco.

@konstantinstadler
Copy link
Member

Hi, changes in the files are ok, but it seems you did not run the linter before submitting (isort and black)

@coveralls
Copy link

coveralls commented Nov 13, 2024

Coverage Status

coverage: 97.078% (+0.05%) from 97.03%
when pulling fdc4733 on mabudz:bonsai
into d0454b7 on IndEcol:master.

@mabudz
Copy link
Contributor Author

mabudz commented Nov 14, 2024

please do not merge, we found and issue that we want to fix

@konstantinstadler
Copy link
Member

sure, please let me know when it is ready

@mabudz
Copy link
Contributor Author

mabudz commented Nov 14, 2024

I pushed some updates to fix an issue on how coco was dealing with the numerical codes. In the previous version of coco all the codes were returned as floats when doing like that:

cc = coco.CountryConverter()
gbd_codes = cc.GBDcode.GBDcode

However, I would expect that all codes are integers so that coco.convert(gbd_codes ,src="GBDcode", to="ISO2") works without having all "not found" inside the series.

So, I revised in that regard.

Furthermore, the newly added GEOnumeric codes are now also treated as integers instead of strings. This makes it obsolete to add other classifications that are using "001" instead of "0001".

@konstantinstadler konstantinstadler merged commit 2651d65 into IndEcol:master Nov 15, 2024
13 of 14 checks passed
@konstantinstadler
Copy link
Member

Great, thanks a lot @mabudz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants