-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bonsai #159
Bonsai #159
Conversation
Hi, changes in the files are ok, but it seems you did not run the linter before submitting (isort and black) |
please do not merge, we found and issue that we want to fix |
sure, please let me know when it is ready |
I pushed some updates to fix an issue on how coco was dealing with the numerical codes. In the previous version of coco all the codes were returned as
However, I would expect that all codes are So, I revised in that regard. Furthermore, the newly added |
Great, thanks a lot @mabudz |
The PR adds the following synonyms to existing classifications:
to
ISOnumeric
:to
EXIO3
:Furthermore, a new classification
GEOnumeric
has been added:Since the original codes for GEOnumeric is a 4-digit, which starts with "0", I decided to treat those as strings in coco.