Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize-checks #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

faizanu94
Copy link

No description provided.

@achingbrain
Copy link
Collaborator

I find this harder to ready, certainly hiding assignment away in a ternary raises an eyebrow. It also won't work if the user passes an undefined value for the final argument, though it's debatable if that should be supported.

You have provided no description, does this solve a problem you've been having?

@faizanu94
Copy link
Author

Hi @achingbrain - it doesn't solve any problem, however I just had a thought to reduce line of code. Further about hiding the assignment in ternary - it's also possible there, but since all test cases were passing without it, I thought to drop that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants