Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis CI badges no longer detected #56

Open
Krinkle opened this issue Aug 24, 2020 · 0 comments
Open

Travis CI badges no longer detected #56

Krinkle opened this issue Aug 24, 2020 · 0 comments

Comments

@Krinkle
Copy link

Krinkle commented Aug 24, 2020

[![Build Status](https://travis-ci.com/cssjanus/cssjanus.svg?branch=master)](https://travis-ci.com/cssjanus/cssjanus) [![npm](https://img.shields.io/npm/v/cssjanus.svg?style=flat)](https://www.npmjs.com/package/cssjanus)

Results in:

//> Array(1)
[ { urls:
     { original: 'https://img.shields.io/npm/v/cssjanus.svg?style=flat',
       shields: 'https://img.shields.io/npm/v/cssjanus.svg',
       content: 'https://img.shields.io/npm/v/cssjanus.json' },
    info: { service: 'npm', type: 'version', modifiers: [Object] } } ]

It looks like the repo has not been updated for the Travis CI migration from dot-org to dot-com from a few years ago, which includes most open-source projects.
Krinkle added a commit to Krinkle/node-detect-readme-badges that referenced this issue Aug 24, 2020
@Krinkle
fix(travis): Recognise travis-ci.com URLs
55bcce0 
As the transition to travis-ci.com is nearing completion, the
legacy dot-org URLs are becoming more and more rare, which is
negatively affecting the package quality score on <https://npms.io/>

* Recognise travis-ci.com URLs.
* Recognise the site (org vs com) because otherwise the API URL
  that we return will not work as expected (they are different
  realms, not aliased!).
* Move the canonical URL detection higher up because it is
  important that we parse dot-org vs dot-com correctly if it is
  available.

Fixes IndigoUnited#56.
@Krinkle Krinkle mentioned this issue Aug 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(travis): Recognise travis-ci.com URLs Krinkle/node-detect-readme-badges
1 participant
@Krinkle