fix(travis): Recognise travis-ci.com URLs #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the transition to travis-ci.com is nearing completion, the legacy dot-org URLs are becoming more and more rare, which is negatively affecting the package quality score on <https://npms.io/> * Recognise travis-ci.com URLs. * Recognise the site (org vs com) because otherwise the API URL that we return will not work as expected (they are different realms, not aliased!). * Move the canonical URL detection higher up because it is important that we parse dot-org vs dot-com correctly if it is available. Fixes IndigoUnited#56.
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the transition to travis-ci.com is nearing completion, the
legacy dot-org URLs are becoming more and more rare, which is
negatively affecting the package quality score on https://npms.io/
I have left the default unchanged, which means it will continue to use
.orgby default if the badge only contains third-party (indirect) URLs. This should probably change in the future but kept as-is for now to make the commit uncontroversial.Fixes #56.