Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace C defines with Rust features + feature lock rust code #29

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

Indra-db
Copy link
Owner

No description provided.

Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the comments ... I think they should get resolved but maybe in a follow up?

//#define FLECS_APP /**< Application addon */
//#define FLECS_OS_API_IMPL /**< Default implementation for OS API */
//#define FLECS_HTTP /**< Tiny HTTP server for connecting to remote UI */
//#define FLECS_REST /**< REST API for querying application data */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could just define FLECS_CUSTOM_BUILD and then you wouldn't need to modify this file.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, would be easier when upgrading as well to not have to keep doing this

//
//#ifdef FLECS_PLECS
//#define FLECS_EXPR
//#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this because you get re-definition warnings? (This should be changed upstream to be more like:

#if defined(FLECS_PLECS) && !defined(FLECS_EXPR)
#define FLECS_EXPR
#endif

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup indeed, maybe I'll PR this soon-ish to flecs

@Indra-db Indra-db merged commit 5855fc5 into master Mar 26, 2024
7 checks passed
@Indra-db Indra-db deleted the replace-C-defines-with-cargo-features branch May 30, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants