Rework iterable to allow Immutable components refs + placed in any order in the tuple list (same for Optional Components) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indra-db
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously you could only create queries where the last type parameters could be optional types, which may or may not be present. This caused a lot of code bloat which was hard to maintain. Through heavy refactoring this bloat has been eliminated and now optional components can be in any order within the tuple list.
Immutable components in query's are supported now.
Iterable implementation got a lot cleaner, easier to maintain and further extendible if desired. We could for example introduce custom wrappers such as Singleton instead of using .term_at(i).singleton()