New Indy package separate from the one in protocols. Includes work f… #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlebeau
reviewed
Aug 20, 2024
rlebeau
reviewed
Aug 20, 2024
rlebeau
reviewed
Aug 20, 2024
rlebeau
reviewed
Aug 20, 2024
rlebeau
reviewed
Aug 20, 2024
rlebeau
reviewed
Aug 20, 2024
rlebeau
reviewed
Aug 20, 2024
|
OK. That's why I called it a strawman - to find out where the reclines are...Sent from my Galaxy
-------- Original message --------From: Remy Lebeau ***@***.***> Date: 20/08/2024 18:49 (GMT+00:00) To: IndySockets/IndyTLS-OpenSSL ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [IndySockets/IndyTLS-OpenSSL] New Indy package separate from the one in protocols. Includes work f… (PR #9)
@rlebeau commented on this pull request.
On IdSSLOpenSSLHeaders_static.pas:
Is this code now gone completely? Or is it being incorporated into the new loader logic? We do need to support static-linking of OpenSSL, such as on iOS. There have been requests to support static-linking on other platforms, such as Windows.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
Oops. Replied to the wrong email.Sent from my Galaxy
-------- Original message --------From: "tony.whyman" ***@***.***> Date: 20/08/2024 19:12 (GMT+00:00) To: IndySockets/IndyTLS-OpenSSL ***@***.***>, IndySockets/IndyTLS-OpenSSL ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [IndySockets/IndyTLS-OpenSSL] New Indy package separate from the one in protocols. Includes work f… (PR #9) OK. That's why I called it a strawman - to find out where the reclines are...Sent from my Galaxy-------- Original message --------From: Remy Lebeau ***@***.***> Date: 20/08/2024 18:49 (GMT+00:00) To: IndySockets/IndyTLS-OpenSSL ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [IndySockets/IndyTLS-OpenSSL] New Indy package separate from the one in protocols. Includes work f… (PR #9)
@rlebeau commented on this pull request.
On IdSSLOpenSSLHeaders_static.pas:
Is this code now gone completely? Or is it being incorporated into the new loader logic? We do need to support static-linking of OpenSSL, such as on iOS. There have been requests to support static-linking on other platforms, such as Windows.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
> Subject: Re: [IndySockets/IndyTLS-OpenSSL] New Indy package separate from the one in protocols. Includes work f… (PR #9) @rlebeau commented on this pull request. On IdSSLOpenSSLHeaders_static.pas: Is this code now gone completely? Or is it being incorporated into the new loader logic? We do need to support static-linking of OpenSSL, such as on iOS. There have been requests to support static-linking on other platforms, such as Windows. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.*> It was a mistake on my part. I have checked the file back in. |
…f DH parameter file.
…s violations if GetCurrentCipher returns nil. 2) added new OnSSLNegotiated event to TIdSSLIOHandlerSocketOpenSSL so we know when negiation is finished and get things like Cipher information. 3) Removed some code for legacy OpenSSL versions that are no longer supported in this code base.
… GUI certificate validation dialog-box prompt.
…ons so that this can work.
…fy account information and server port.
… to accept-only once in certificate viewer prompt.
… since those were discontinued in OpenSSL 3.x and we werent using them anyway. See: openssl/openssl#14216
…_email_free. added safestack unit for some safestack.h definitions we may need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rom Tony Whyman