Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radio-button, Checkbox and Switch: align to web standards #1479

Closed
tishoyanchev opened this issue Sep 18, 2024 · 0 comments · Fixed by #1485
Closed

Radio-button, Checkbox and Switch: align to web standards #1479

tishoyanchev opened this issue Sep 18, 2024 · 0 comments · Fixed by #1485
Assignees
@pfafffabian-ifx
Labels
bug Something isn't working enhancement Adding a new feature or improving existing code

Comments

@tishoyanchev
Copy link
Contributor

tishoyanchev commented Sep 18, 2024 •
edited
Loading

radio-button, checkbox and switch components have a value property instead of checked prop. Replace value with checked for on/off behavior, and introduce 'value' as a string.
In addition:
Two radio-buttons with the same name attribute do not toggle because the radio-button component is made up of

elements. The input element is missing.
Integrate the Input element following the example of the checkbox component, and make sure two radio-buttons with the same name toggle.

Related issue: #1476
@tishoyanchev tishoyanchev added bug Something isn't working enhancement Adding a new feature or improving existing code labels Sep 18, 2024
@tishoyanchev tishoyanchev moved this from Low Priority to High Priority in Infineon Digital Design System - Public Board Sep 18, 2024
@tishoyanchev tishoyanchev changed the title radio-button: integrate input element Radio-button, Checkbox and Switch: align to web standards Sep 19, 2024
@pfafffabian-ifx pfafffabian-ifx linked a pull request Sep 19, 2024 that will close this issue
Align Radio-Button, Checkbox and Switch to web standards #1485
Merged
@pfafffabian-ifx pfafffabian-ifx mentioned this issue Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pfafffabian-ifx pfafffabian-ifx

Labels
bug Something isn't working enhancement Adding a new feature or improving existing code
Projects
Infineon Digital Design System - Public Board
Status: Released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Align Radio-Button, Checkbox and Switch to web standards Infineon/infineon-design-system-stencil
2 participants
@tishoyanchev @pfafffabian-ifx